-
Notifications
You must be signed in to change notification settings - Fork 735
fix: index schema sync race #28711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: index schema sync race #28711
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a race condition in schema version synchronization for index implementation tables during CDC (Change Data Capture) continuous backup operations.
Key Changes:
- Removed unconditional
table->AlterVersion += 1at the start and replaced with conditional logic based on table type and operation context - Enhanced continuous backup detection for index implementation tables by checking parent table's CDC streams
- Implemented version synchronization logic that prevents version drift between parent tables, index entities, and index implementation tables using
Max()to handle race conditions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp
Outdated
Show resolved
Hide resolved
cf92c7d to
d57cb16
Compare
CyberROFL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А тест будет?
|
@Enjection прилинкуй issue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Нет. Непонятно как правильно это потестить, у нас сейчас в тестах нельзя поменять порядок операций в SS вручную. Есть некоторые мысли как научиться, но это приключение не на 5 минут. |
d57cb16 to
023a765
Compare
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...