Skip to content

[25.3.1] Sequential reads for BATCH queries (#28906) #28923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

[25.3.1] Sequential reads for BATCH queries (#28906) #28923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ydb/core/kqp/runtime/kqp_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ class TKqpReadActor : public TActorBootstrapped<TKqpReadActor>, public NYql::NDq
}

bool StartShards() {
const ui32 maxAllowedInFlight = Settings->GetSorted() ? 1 : MaxInFlight;
const ui32 maxAllowedInFlight = Settings->GetSorted() || Settings->GetIsBatch() ? 1 : MaxInFlight;
CA_LOG_D("effective maxinflight " << maxAllowedInFlight << " sorted " << Settings->GetSorted());
bool isFirst = true;
while (!PendingShards.Empty() && RunningReads() + 1 <= maxAllowedInFlight) {
Expand Down Expand Up @@ -1069,7 +1069,7 @@ class TKqpReadActor : public TActorBootstrapped<TKqpReadActor>, public NYql::NDq
ui64 seqNo = record.GetSeqNo();
Reads[id].RegisterMessage(msg);

if (Settings->GetIsBatch() && msg.GetRowsCount() > 0) {
if (Settings->GetIsBatch() && msg.GetRowsCount() > 0 && BatchOperationMaxRow.GetCells().empty()) {
auto cells = msg.GetCells(msg.GetRowsCount() - 1);
BatchOperationMaxRow = TSerializedCellVec{cells};
}
Expand Down
Loading