Skip to content

Conversation

@Enjection
Copy link
Member

@Enjection Enjection commented Nov 24, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

🟢 2025-11-24 01:03:43 UTC The validation of the Pull Request description is successful.

Copilot finished reviewing on behalf of Enjection November 24, 2025 01:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds debugging and observability features to the ConfigsDispatcher component to help diagnose configuration source issues. The changes enable better visibility into how the system was configured (via seed nodes or dynamic config) and provide new diagnostic APIs.

  • Added StartupStorageYaml field to track storage configuration from seed nodes
  • Introduced new observability events (TEvGetStateRequest, TEvGetStorageYamlRequest) for runtime introspection
  • Split unit tests into separate test targets for better organization

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ydb/core/config/init/init.h Added StartupStorageYaml field to TConfigsDispatcherInitInfo struct
ydb/core/config/init/init_impl.h Updated initialization logic to propagate StartupStorageYaml from app config
ydb/core/cms/console/configs_dispatcher_observer.h New header defining EConfigSource enum and TConfigsDispatcherState struct for observability
ydb/core/cms/console/configs_dispatcher.h Added new event types for state queries and storage YAML retrieval
ydb/core/cms/console/configs_dispatcher.cpp Implemented observability handlers, config source detection, and enhanced monitoring page with storage YAML display
ydb/core/cms/console/ya.make Added new observer header to build and reorganized test targets
ydb/core/cms/console/ut_console/ya.make Removed dispatcher-specific tests, moved to separate target
ydb/core/cms/console/ut_configs_dispatcher/ya.make New test target specifically for configs dispatcher tests
ydb/core/cms/console/configs_dispatcher_ut.cpp Added comprehensive tests for new observability features covering seed nodes, dynamic config, and unknown config sources

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

2025-11-24 01:04:11 UTC Pre-commit check linux-x86_64-release-asan for 2b430cc has started.
2025-11-24 01:04:28 UTC Artifacts will be uploaded here
2025-11-24 01:06:37 UTC ya make is running...
🟡 2025-11-24 02:38:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12733 12545 0 144 28 16

🟢 2025-11-24 02:38:52 UTC Build successful.
🟢 2025-11-24 02:39:16 UTC ydbd size 3.8 GiB changed* by +99.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d14cebe merge: 2b430cc diff diff %
ydbd size 4 109 494 336 Bytes 4 109 596 256 Bytes +99.5 KiB +0.002%
ydbd stripped size 1 527 403 056 Bytes 1 527 438 992 Bytes +35.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

2025-11-24 01:06:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b430cc has started.
2025-11-24 01:06:57 UTC Artifacts will be uploaded here
2025-11-24 01:08:55 UTC ya make is running...
🟢 2025-11-24 02:52:49 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39699 36827 0 0 2839 33

🟢 2025-11-24 02:53:01 UTC Build successful.
🟢 2025-11-24 02:53:23 UTC ydbd size 2.3 GiB changed* by +62.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d14cebe merge: 2b430cc diff diff %
ydbd size 2 454 898 248 Bytes 2 454 962 608 Bytes +62.9 KiB +0.003%
ydbd stripped size 523 165 528 Bytes 523 177 560 Bytes +11.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection requested review from stanislav-shchetinin and removed request for vporyadke November 25, 2025 10:35
@Enjection Enjection merged commit 494e7ea into ydb-platform:main Nov 25, 2025
20 of 21 checks passed
@Enjection Enjection deleted the bugfix/configs/debug-seed-nodes-001 branch November 25, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants