-
Notifications
You must be signed in to change notification settings - Fork 735
fix: seed nodes configs dispatcher debug #29392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: seed nodes configs dispatcher debug #29392
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds debugging and observability features to the ConfigsDispatcher component to help diagnose configuration source issues. The changes enable better visibility into how the system was configured (via seed nodes or dynamic config) and provide new diagnostic APIs.
- Added
StartupStorageYamlfield to track storage configuration from seed nodes - Introduced new observability events (
TEvGetStateRequest,TEvGetStorageYamlRequest) for runtime introspection - Split unit tests into separate test targets for better organization
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/core/config/init/init.h | Added StartupStorageYaml field to TConfigsDispatcherInitInfo struct |
| ydb/core/config/init/init_impl.h | Updated initialization logic to propagate StartupStorageYaml from app config |
| ydb/core/cms/console/configs_dispatcher_observer.h | New header defining EConfigSource enum and TConfigsDispatcherState struct for observability |
| ydb/core/cms/console/configs_dispatcher.h | Added new event types for state queries and storage YAML retrieval |
| ydb/core/cms/console/configs_dispatcher.cpp | Implemented observability handlers, config source detection, and enhanced monitoring page with storage YAML display |
| ydb/core/cms/console/ya.make | Added new observer header to build and reorganized test targets |
| ydb/core/cms/console/ut_console/ya.make | Removed dispatcher-specific tests, moved to separate target |
| ydb/core/cms/console/ut_configs_dispatcher/ya.make | New test target specifically for configs dispatcher tests |
| ydb/core/cms/console/configs_dispatcher_ut.cpp | Added comprehensive tests for new observability features covering seed nodes, dynamic config, and unknown config sources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...