-
Notifications
You must be signed in to change notification settings - Fork 739
Export / import s3 for topics configuration docs #30232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Export / import s3 for topics configuration docs #30232
Conversation
|
⚪
🟢 |
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for exporting and importing topics (schema only, without messages) to/from S3-compatible storage in both English and Russian documentation.
Key changes:
- Added topics to the list of exportable object types in S3 export documentation
- Added a new "Topics" section describing the file structure for exported topics
- Updated list formatting for consistency (semicolons)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ydb/docs/ru/core/reference/ydb-cli/export-import/_includes/file-structure.md | Adds "Topics" section explaining that each topic has a directory with create_topic.pb file containing topic parameters in text protobuf format |
| ydb/docs/ru/core/reference/ydb-cli/export-import/_includes/export-s3.md | Adds topic to the list of exportable objects, fixes list punctuation consistency |
| ydb/docs/en/core/reference/ydb-cli/export-import/_includes/s3_export.md | Adds topic to the list of exportable objects (English version) |
| ydb/docs/en/core/reference/ydb-cli/export-import/_includes/file_structure.md | Adds "Topics" section describing the topic export file structure (English version) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - [Row-oriented table](../../../../concepts/datamodel/table.md#row-oriented-tables) | ||
| - [Secondary index](../../../../concepts/glossary.md#secondary-index) | ||
| - [Vector index](../../../../concepts/glossary.md#vector-index) | ||
| - [Topic](../../../../concepts/datamodel/topic.md) () |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parentheses appear to be incomplete. Based on the Russian version of this file, this should read "(only the schema, without messages)" to match the description "только схема, без сообщений".
| - [Topic](../../../../concepts/datamodel/topic.md) () | |
| - [Topic](../../../../concepts/datamodel/topic.md) (only the schema, without messages) |
| - [векторный индекс](../../../../concepts/glossary.md#vector-index). | ||
| - [вторичный индекс](../../../../concepts/glossary.md#secondary-index); | ||
| - [векторный индекс](../../../../concepts/glossary.md#vector-index); | ||
| - [топик](../../../../concepts/datamodel/topic.md) (only the schema, without messages). |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent use of language. The line contains Russian text "только схема, без сообщений" within English documentation. This should be translated to English: "(only the schema, without messages)".
| - [топик](../../../../concepts/datamodel/topic.md) (only the schema, without messages). | |
| - [топик](../../../../concepts/datamodel/topic.md) (только схема, без сообщений). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поддерживаю.
|
|
||
| ## Topics {#topics} | ||
|
|
||
| For each topic in the database, there's a same-name directory in the file structure's directory hierarchy that includes the create_topic.pb file. This file provides information about the topic parameters, partitioning settings, and consumers in the [text protobuf](https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.text_format) format. |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename create_topic.pb should be formatted with backticks for consistency with other file references in the documentation (e.g., changefeed_description.pb and topic_description.pb on lines 73-74).
| For each topic in the database, there's a same-name directory in the file structure's directory hierarchy that includes the create_topic.pb file. This file provides information about the topic parameters, partitioning settings, and consumers in the [text protobuf](https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.text_format) format. | |
| For each topic in the database, there's a same-name directory in the file structure's directory hierarchy that includes the `create_topic.pb` file. This file provides information about the topic parameters, partitioning settings, and consumers in the [text protobuf](https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.text_format) format. |
✅ Documentation buildRevision built successfully Build logsWarnings (4) |
|
⚪
🟢 |
| - [векторный индекс](../../../../concepts/glossary.md#vector-index). | ||
| - [вторичный индекс](../../../../concepts/glossary.md#secondary-index); | ||
| - [векторный индекс](../../../../concepts/glossary.md#vector-index); | ||
| - [топик](../../../../concepts/datamodel/topic.md) (only the schema, without messages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поддерживаю.
| - [векторный индекс](../../../../concepts/glossary.md#vector-index). | ||
| - [вторичный индекс](../../../../concepts/glossary.md#secondary-index); | ||
| - [векторный индекс](../../../../concepts/glossary.md#vector-index); | ||
| - [топик](../../../../concepts/datamodel/topic.md) (only the schema, without messages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [топик](../../../../concepts/datamodel/topic.md) (only the schema, without messages). | |
| - [топик](../../../../concepts/datamodel/topic.md) (только схема). |
Changelog entry
...
Changelog category
Description for reviewers
...