Skip to content

Conversation

@yeonjuan
Copy link
Owner

@yeonjuan yeonjuan commented Aug 9, 2025

Checklist

  • Addresses an existing open issue: fixes #000

Description

@yeonjuan yeonjuan requested a review from Copilot August 9, 2025 14:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the browser compatibility data (BCD) for use in baseline feature detection. The changes include updating the BCD dependency version and adding new HTML input element compatibility entries.

  • Updates @mdn/browser-compat-data dependency from version 6.0.27 to 6.1.1
  • Adds new baseline compatibility entries for HTML input elements including color input CSS color support and range input features
  • Updates Node.js version from 20.9.0 to 22.14.0

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/eslint-plugin/lib/rules/utils/baseline.js Adds new BCD entries for input element features and updates existing baseline version for range tick marks
package.json Updates @mdn/browser-compat-data dependency to version 6.1.1
.nvmrc Updates Node.js version to v22.14.0

["ol.type", "10:2015"],
["optgroup", "10:2015"],
["optgroup.disabled", "10:2015"],
["optgroup.disabled", "0:"],
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseline version for optgroup.disabled has been changed from "10:2015" to "0:", which indicates no baseline support. This appears to be incorrect as optgroup.disabled is a well-established HTML feature that should have baseline support. Please verify this change against the actual BCD data.

Suggested change
["optgroup.disabled", "0:"],
["optgroup.disabled", "10:2015"],

Copilot uses AI. Check for mistakes.
["input.type_range", "10:2017"],
["input.type_range.tick_marks", "5:2023"],
["input.type_range.labeled_values", "0:"],
["input.type_range.tick_marks", "10:2023"],
Copy link

Copilot AI Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseline version for input.type_range.tick_marks has been changed from "5:2023" to "10:2023", which represents a significant change in browser support timeline. Please verify this change is accurate as it affects when this feature is considered baseline-supported.

Suggested change
["input.type_range.tick_marks", "10:2023"],
["input.type_range.tick_marks", "5:2023"],

Copilot uses AI. Check for mistakes.
@yeonjuan yeonjuan merged commit 8b4d57a into main Aug 9, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (1056c3b) to head (8c96968).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          83       83           
  Lines        2716     2716           
  Branches      756      756           
=======================================
  Hits         2677     2677           
  Misses         39       39           
Flag Coverage Δ
unittest 98.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/lib/rules/utils/baseline.js 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants