-
-
Notifications
You must be signed in to change notification settings - Fork 51
feat: update bcd for use-baseline #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the browser compatibility data (BCD) for use in baseline feature detection. The changes include updating the BCD dependency version and adding new HTML input element compatibility entries.
- Updates
@mdn/browser-compat-datadependency from version 6.0.27 to 6.1.1 - Adds new baseline compatibility entries for HTML input elements including color input CSS color support and range input features
- Updates Node.js version from 20.9.0 to 22.14.0
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/eslint-plugin/lib/rules/utils/baseline.js | Adds new BCD entries for input element features and updates existing baseline version for range tick marks |
| package.json | Updates @mdn/browser-compat-data dependency to version 6.1.1 |
| .nvmrc | Updates Node.js version to v22.14.0 |
| ["ol.type", "10:2015"], | ||
| ["optgroup", "10:2015"], | ||
| ["optgroup.disabled", "10:2015"], | ||
| ["optgroup.disabled", "0:"], |
Copilot
AI
Aug 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The baseline version for optgroup.disabled has been changed from "10:2015" to "0:", which indicates no baseline support. This appears to be incorrect as optgroup.disabled is a well-established HTML feature that should have baseline support. Please verify this change against the actual BCD data.
| ["optgroup.disabled", "0:"], | |
| ["optgroup.disabled", "10:2015"], |
| ["input.type_range", "10:2017"], | ||
| ["input.type_range.tick_marks", "5:2023"], | ||
| ["input.type_range.labeled_values", "0:"], | ||
| ["input.type_range.tick_marks", "10:2023"], |
Copilot
AI
Aug 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The baseline version for input.type_range.tick_marks has been changed from "5:2023" to "10:2023", which represents a significant change in browser support timeline. Please verify this change is accurate as it affects when this feature is considered baseline-supported.
| ["input.type_range.tick_marks", "10:2023"], | |
| ["input.type_range.tick_marks", "5:2023"], |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 83 83
Lines 2716 2716
Branches 756 756
=======================================
Hits 2677 2677
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Checklist
Description