feat: support linting doctype in lowercase #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for linting doctype declarations to ensure they are in lowercase. The feature addresses issue #410 by detecting and automatically fixing doctype declarations that aren't fully lowercase (e.g., <!DOCTYPE html> or <!doctype HTML>).
Key changes:
- Extended the lowercase ESLint rule to handle
Doctypenodes in addition to existing tag types - Added comprehensive test coverage for various doctype capitalization scenarios
- Updated example HTML to use the preferred lowercase doctype format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/eslint-plugin/lib/rules/lowercase.js | Added checkDoctype function and visitor to lint doctype declarations |
| packages/eslint-plugin/tests/rules/lowercase.test.js | Added test cases for valid and invalid doctype scenarios |
| packages/website/src/scripts/playground/helpers.js | Updated example HTML to use lowercase doctype |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 98.53% 98.50% -0.03%
==========================================
Files 83 83
Lines 2733 2748 +15
Branches 763 769 +6
==========================================
+ Hits 2693 2707 +14
- Misses 40 41 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Nightfirecat
force-pushed
the
feat-check-lowercase-doctype
branch
from
f811d81 to
f2e2f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This commit adds detection and fixers of not-lowercase doctypes in documents, eg.
<!DOCTYPE html>,<!doctype HTML>, or any other capitalization besides the all-lowercased<!doctype html>.I originally wanted to condense the changes to the rule in a single generalized
check()function, but that ended up feeling kludgy because of the different shape ofDoctypeversus the existing assumptions for the inputTag | StyleTag | ScriptTagtypes. As a result, there is some duplicated code in my implementation here--I'd be happy to clean that up if there is a more ideal structure you'd like to see.