Skip to content

Conversation

@yeonjuan
Copy link
Owner

@yeonjuan yeonjuan commented Sep 3, 2025

Checklist

Description

@yeonjuan yeonjuan requested a review from Copilot September 3, 2025 13:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the dependency classification of @html-eslint/types by moving it from devDependencies to dependencies across multiple packages to ensure proper runtime availability.

  • Moves @html-eslint/types from devDependencies to dependencies in four packages
  • Ensures runtime availability of type definitions for consuming applications
  • Maintains consistent dependency structure across the monorepo

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/template-syntax-parser/package.json Moves @html-eslint/types from devDependencies to dependencies
packages/template-parser/package.json Moves @html-eslint/types from devDependencies to dependencies
packages/parser/package.json Moves @html-eslint/types from devDependencies to dependencies
packages/eslint-plugin/package.json Moves @html-eslint/types from devDependencies to dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yeonjuan yeonjuan merged commit 479f3ce into main Sep 3, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.54%. Comparing base (30d2b2e) to head (7eca625).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          83       83           
  Lines        2751     2751           
  Branches      768      768           
=======================================
  Hits         2711     2711           
  Misses         40       40           
Flag Coverage Δ
unittest 98.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Missing types for the plugin package

2 participants