Mingw32 error (poll was not declared) + strange "poll" def/undef in splitted header.

[Chuvi-w]

Here is #define poll.

cpp-httplib/httplib.h

Line 197 in 37399af

#define poll(fds, nfds, timeout) WSAPoll(fds, nfds, timeout)

Here is #undef poll.

cpp-httplib/httplib.h

Line 10381 in 37399af

#undef poll

When splitted to httplib.cc and httplib.h files, "#define poll" and "#undef poll" remains in httplib.h file.
"poll" itself not used in splitted httplib.h, but in httplib.cc it comes after "#undef poll", if we have _WIN32 defined.

Seems that "#define poll" and "#undef poll" should be in "httplib.cc " when httplib.h is splitted into .h and .cc parts.

(I have no idea how or why it compiles in Windows.)

[falbrechtskirchinger]

MinGW is not officially supported or tested: https://github.com/yhirose/cpp-httplib#windows

That said, if you find an easy fix, submit a PR.

[Chuvi-w]

At least it compiled successfully. But I did not check its functionality, as there is no Windows PC nearby.
But, as it seems to me, the issue there refers not only to Mingw32, but to the fact that #undef is called at the end of the header, so #defined value not passed to .cc file.

[falbrechtskirchinger]

(...) the fact that #undef is called at the end of the header, so #defined value not passed to .cc file.

I did catch that, and I'm checking it at the moment.

Edit: Yes, it fails on Windows, too. This is not a MinGW issue.

D:\a\cpp-httplib\cpp-httplib\build\out\httplib.cc(614,47): error C3861: 'poll': identifier not found [D:\a\cpp-httplib\cpp-httplib\build\httplib.vcxproj]