Skip to content

Fix bugprone warnings #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix bugprone warnings #1721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions httplib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,7 +2227,7 @@ inline std::string from_i_to_hex(size_t n) {

inline size_t to_utf8(int code, char *buff) {
if (code < 0x0080) {
buff[0] = (code & 0x7F);
buff[0] = static_cast<char>(code & 0x7F);
return 1;
} else if (code < 0x0800) {
buff[0] = static_cast<char>(0xC0 | ((code >> 6) & 0x1F));
Expand Down Expand Up @@ -2835,7 +2835,7 @@ class SocketStream : public Stream {
size_t read_buff_off_ = 0;
size_t read_buff_content_size_ = 0;

static const size_t read_buff_size_ = 1024 * 4;
static const size_t read_buff_size_ = 1024l * 4;
};

#ifdef CPPHTTPLIB_OPENSSL_SUPPORT
Expand Down Expand Up @@ -3804,7 +3804,7 @@ inline bool read_content_chunked(Stream &strm, T &x,

if (!line_reader.getline()) { return false; }

if (strcmp(line_reader.ptr(), "\r\n")) { return false; }
if (strcmp(line_reader.ptr(), "\r\n") != 0) { return false; }

if (!line_reader.getline()) { return false; }
}
Expand All @@ -3814,7 +3814,7 @@ inline bool read_content_chunked(Stream &strm, T &x,
// Trailer
if (!line_reader.getline()) { return false; }

while (strcmp(line_reader.ptr(), "\r\n")) {
while (strcmp(line_reader.ptr(), "\r\n") != 0) {
if (line_reader.size() > CPPHTTPLIB_HEADER_MAX_LENGTH) { return false; }

// Exclude line terminator
Expand Down