-
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: Update workflow actions to use v1 stable version instead of main, update LICENSE.md.
#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in, update `LICENSE.md`.
WalkthroughBroadened .gitattributes export-ignore patterns. Pinned multiple GitHub Actions workflow “uses” references from @main to @v1. Added a changelog entry for these updates. Updated the BSD-3-Clause license endorsement text to reference “Yii2 Extensions (Terabytesoftw).” Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
========================================
Coverage ? 100.00%
Complexity ? 71
========================================
Files ? 2
Lines ? 129
Branches ? 0
========================================
Hits ? 129
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
v1 stable instead of main, update LICENSE.md.v1 stable version instead of main, update LICENSE.md.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/dependency-check.yml (1)
20-23: Optional hardening: restrict GITHUB_TOKEN permissions in this workflow.To follow least-privilege best practices, consider explicitly restricting permissions (top-level or per-job). Example:
permissions: contents: read
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.gitattributes(1 hunks).github/workflows/build.yml(1 hunks).github/workflows/dependency-check.yml(1 hunks).github/workflows/ecs.yml(1 hunks).github/workflows/static.yml(1 hunks)CHANGELOG.md(1 hunks)LICENSE.md(1 hunks)
🔇 Additional comments (7)
.github/workflows/ecs.yml (1)
22-22: ecs.yml at v1 confirmed, no input changes
The reusable workflow exists under the v1 tag and all input names match main—no further action needed.CHANGELOG.md (1)
7-7: Changelog entry reads well and matches the PR scope.Accurately documents pinning actions to v1 and the license update.
LICENSE.md (1)
14-16: License endorsement line updated correctly.The BSD-3-Clause clause now reflects the intended project entity (“Yii2 Extensions (Terabytesoftw)”). No legal structure issues spotted.
.github/workflows/build.yml (1)
22-22: Confirmed phpunit.yml@v1 compatibility –composer-command,extensions,concurrency-groupand theCODECOV_TOKENsecret are all defined in the v1 workflow, so pinning to@v1is safe..github/workflows/static.yml (1)
26-26: Confirmed:phpstan.yml@v1Supports Required InputsI fetched and decoded
phpstan.yml@v1fromphp-forge/actionsand verified that both
configurationconcurrency-group
are defined underworkflow_call.inputs.You can safely proceed with the pin to
@v1..github/workflows/dependency-check.yml (1)
22-22: Verification successful:v1ref and workflow file confirmed.
Good pin to stable@v1for the reusable workflow—switching from@mainto@v1reduces breakage risk from upstream changes. Nice..gitattributes (1)
38-39: Export-ignore patterns verified
/infection.json*currently matches no files (noinfection.jsonvariants at repo root)/phpstan*.neon*matchesphpstan.neonandphpstan-console.neon, both export-ignored as expectedIf your goal is to broadly exclude current and future PHPStan and Infection config files from release archives, this setup is correct.
Summary by CodeRabbit
Chores
Documentation