Skip to content

test(http): Rename test method for clarity and remove redundant test for unlimited memory limit in ApplicationMemoryTest class. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2025
Merged

test(http): Rename test method for clarity and remove redundant test for unlimited memory limit in ApplicationMemoryTest class. #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526863b
test(http): Rename test method for clarity and remove redundant test …
terabytesoftw Aug 23, 2025
3e27c72
Apply fixed review coderabbitai nitpick comments.
terabytesoftw Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions tests/http/stateless/ApplicationMemoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public function testClearOutputCleansLocalBuffers(): void
/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
public function testGetMemoryLimitHandlesUnlimitedMemoryCorrectly(): void
public function testMemoryLimitHandlesUnlimitedValues(): void
{
$originalLimit = ini_get('memory_limit');

Expand All @@ -179,39 +179,16 @@ public function testGetMemoryLimitHandlesUnlimitedMemoryCorrectly(): void
self::assertSame(
PHP_INT_MAX,
$app->getMemoryLimit(),
"Memory limit should be 'PHP_INT_MAX' when set to '-1' (unlimited) in 'StatelessApplication'.",
"Before 'handle()' memory limit should be 'PHP_INT_MAX' when set to '-1' (unlimited).",
);

$app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());
$app->clean();

ini_set('memory_limit', $originalLimit);
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
public function testReturnPhpIntMaxWhenMemoryLimitIsUnlimited(): void
{
$originalLimit = ini_get('memory_limit');

ini_set('memory_limit', '-1');

$app = $this->statelessApplication();

$app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());

self::assertSame(
PHP_INT_MAX,
$app->getMemoryLimit(),
"'getMemoryLimit()' should return 'PHP_INT_MAX' when 'memory_limit' is set to '-1' (unlimited) in " .
"'StatelessApplication'.",
);
self::assertSame(
PHP_INT_MAX,
$app->getMemoryLimit(),
"'getMemoryLimit()' should remain 'PHP_INT_MAX' after handling a request with unlimited memory in " .
"'StatelessApplication'.",
"After 'clean()' memory limit should remain 'PHP_INT_MAX' when set to '-1'.",
);

ini_set('memory_limit', $originalLimit);
Expand Down
Loading