Skip to content

test(http): Move event trigger test from ApplicationTest to ApplicationCoreTest for better organization. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2025
Merged

test(http): Move event trigger test from ApplicationTest to ApplicationCoreTest for better organization. #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9a451c
test(http): Move event trigger test from `ApplicationTest` to `Applic…
terabytesoftw Aug 25, 2025
5c1b7f0
test(http): Enhance event trigger test to verify invocation count and…
terabytesoftw Aug 25, 2025
6481870
Apply fixed review coderabbitai nitpick comments.
terabytesoftw Aug 25, 2025
60b75d8
test(http): Add test for event order during request handling in `Appl…
terabytesoftw Aug 25, 2025
ddb6617
Apply fixed review coderabbitai nitpick comments.
terabytesoftw Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 109 additions & 38 deletions tests/http/stateless/ApplicationCoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
namespace yii2\extensions\psrbridge\tests\http\stateless;

use HttpSoft\Message\{ServerRequestFactory, StreamFactory, UploadedFileFactory};
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\{Group, TestWith};
use Psr\Http\Message\{ServerRequestFactoryInterface, StreamFactoryInterface, UploadedFileFactoryInterface};
use ReflectionException;
use Yii;
use yii\base\{InvalidConfigException, Security};
use yii\base\{Event, InvalidConfigException, Security};
use yii\di\NotInstantiableException;
use yii\i18n\{Formatter, I18N};
use yii\log\Dispatcher;
use yii\web\{AssetManager, Session, UrlManager, User, View};
use yii2\extensions\psrbridge\http\{ErrorHandler, Request, Response};
use yii2\extensions\psrbridge\http\{ErrorHandler, Request, Response, StatelessApplication};
use yii2\extensions\psrbridge\tests\support\FactoryHelper;
use yii2\extensions\psrbridge\tests\support\stub\MockerFunctions;
use yii2\extensions\psrbridge\tests\TestCase;
Expand Down Expand Up @@ -85,6 +85,43 @@ public function testContainerResolvesPsrFactoriesWithDefinitions(): void
);
}

public function testEventOrderDuringHandle(): void
{
$app = $this->statelessApplication();
$sequence = [];

$app->on(
StatelessApplication::EVENT_BEFORE_REQUEST,
static function () use (&$sequence): void {
$sequence[] = 'before';
},
);
$app->on(
StatelessApplication::EVENT_AFTER_REQUEST,
static function () use (&$sequence): void {
$sequence[] = 'after';
},
);

$response = $app->handle(FactoryHelper::createRequest('GET', 'site/index'));

self::assertSame(
200,
$response->getStatusCode(),
"Expected HTTP '200' for route 'site/index'.",
);
self::assertSame(
'application/json; charset=UTF-8',
$response->getHeaderLine('Content-Type'),
"Expected Content-Type 'application/json; charset=UTF-8' for route 'site/index'.",
);
self::assertSame(
['before', 'after'],
$sequence,
"BEFORE should precede AFTER during 'handle()'.",
);
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
* @throws ReflectionException if the property does not exist or is inaccessible.
Expand All @@ -94,14 +131,7 @@ public function testResponseAdapterCachingAndResetBehaviorAcrossMultipleRequests
$app = $this->statelessApplication();

// first request - verify adapter caching behavior
$_SERVER = [
'REQUEST_METHOD' => 'GET',
'REQUEST_URI' => 'site/index',
];

$response1 = $app->handle(
FactoryHelper::createServerRequestCreator()->createFromGlobals(),
);
$response1 = $app->handle(FactoryHelper::createRequest('GET', 'site/index'));

self::assertSame(
200,
Expand Down Expand Up @@ -135,14 +165,7 @@ public function testResponseAdapterCachingAndResetBehaviorAcrossMultipleRequests
);

// second request with different route - verify stateless behavior
$_SERVER = [
'REQUEST_METHOD' => 'GET',
'REQUEST_URI' => 'site/statuscode',
];

$response2 = $app->handle(
FactoryHelper::createServerRequestCreator()->createFromGlobals(),
);
$response2 = $app->handle(FactoryHelper::createRequest('GET', 'site/statuscode'));

self::assertSame(
201,
Expand Down Expand Up @@ -189,15 +212,7 @@ public function testResponseAdapterCachingAndResetBehaviorAcrossMultipleRequests
);

// third request - verify adapter isolation between requests
$_COOKIE = ['test_cookie' => 'test_value'];
$_SERVER = [
'REQUEST_METHOD' => 'GET',
'REQUEST_URI' => 'site/add-cookies-to-response',
];

$response3 = $app->handle(
FactoryHelper::createServerRequestCreator()->createFromGlobals(),
);
$response3 = $app->handle(FactoryHelper::createRequest('GET', 'site/add-cookies-to-response'));

self::assertSame(
200,
Expand Down Expand Up @@ -236,9 +251,14 @@ public function testResponseAdapterCachingAndResetBehaviorAcrossMultipleRequests
"PSR-7 Response should contain 'test=test' or 'test2=test2' in 'Set-Cookie' headers, confirming correct " .
'adapter behavior.',
);
self::assertSame(
'test=test; Path=/; HttpOnly; SameSite=Lax test2=test2; Path=/; HttpOnly; SameSite=Lax',
implode(' ', $cookieHeaders),
self::assertContains(
'test=test; Path=/; HttpOnly; SameSite=Lax',
$cookieHeaders,
'PSR-7 Response Set-Cookie headers should match the expected values, confirming correct adapter behavior.',
);
self::assertContains(
'test2=test2; Path=/; HttpOnly; SameSite=Lax',
$cookieHeaders,
'PSR-7 Response Set-Cookie headers should match the expected values, confirming correct adapter behavior.',
);
}
Expand Down Expand Up @@ -306,14 +326,9 @@ public function testSetsPsr7RequestWithStatelessAppStartTimeHeader(): void

MockerFunctions::setMockedMicrotime($mockedTime);

$_SERVER = [
'REQUEST_METHOD' => 'GET',
'REQUEST_URI' => 'site/index',
];

$app = $this->statelessApplication();

$response = $app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());
$response = $app->handle(FactoryHelper::createRequest('GET', 'site/index'));

self::assertSame(
200,
Expand Down Expand Up @@ -347,8 +362,18 @@ public function testSetWebAndWebrootAliasesAfterHandleRequest(): void
{
$app = $this->statelessApplication();

$app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());
$response = $app->handle(FactoryHelper::createRequest('GET', 'site/index'));

self::assertSame(
200,
$response->getStatusCode(),
"Expected HTTP '200' for route 'site/index'.",
);
self::assertSame(
'application/json; charset=UTF-8',
$response->getHeaderLine('Content-Type'),
"Expected Content-Type 'application/json; charset=UTF-8' for route 'site/index'.",
);
self::assertSame(
'',
Yii::getAlias('@web'),
Expand All @@ -360,4 +385,50 @@ public function testSetWebAndWebrootAliasesAfterHandleRequest(): void
"'@webroot' alias should be set to the parent directory of the test directory after handling a request.",
);
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
#[TestWith([StatelessApplication::EVENT_AFTER_REQUEST])]
#[TestWith([StatelessApplication::EVENT_BEFORE_REQUEST])]
public function testTriggerEventDuringHandle(string $eventName): void
{
$invocations = 0;
$sender = null;
$sequence = [];

$app = $this->statelessApplication();

$app->on(
$eventName,
static function (Event $event) use (&$invocations, &$sequence, &$sender): void {
$invocations++;
$sender = $event->sender ?? null;
$sequence[] = $event->name;
},
);

$response = $app->handle(FactoryHelper::createRequest('GET', 'site/index'));

self::assertSame(
200,
$response->getStatusCode(),
"Expected HTTP '200' for route 'site/index'.",
);
self::assertSame(
'application/json; charset=UTF-8',
$response->getHeaderLine('Content-Type'),
"Expected Content-Type 'application/json; charset=UTF-8' for route 'site/index'.",
);
self::assertSame(
1,
$invocations,
"Should trigger '{$eventName}' exactly once during 'handle()'.",
);
self::assertSame(
$app,
$sender,
'Event sender should be the application instance.',
);
}
}
26 changes: 1 addition & 25 deletions tests/http/stateless/ApplicationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@

namespace yii2\extensions\psrbridge\tests\http\stateless;

use PHPUnit\Framework\Attributes\{Group, RequiresPhpExtension, TestWith};
use PHPUnit\Framework\Attributes\{Group, RequiresPhpExtension};
use yii\base\InvalidConfigException;
use yii2\extensions\psrbridge\http\StatelessApplication;
use yii2\extensions\psrbridge\tests\support\FactoryHelper;
use yii2\extensions\psrbridge\tests\TestCase;

Expand Down Expand Up @@ -256,27 +255,4 @@ public function testReturnsStatusCode201ForSiteStatusCodeRoute(): void
"Response 'status code' should be '201' for 'site/statuscode' route in 'StatelessApplication'.",
);
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
#[TestWith([StatelessApplication::EVENT_AFTER_REQUEST])]
#[TestWith([StatelessApplication::EVENT_BEFORE_REQUEST])]
public function testTriggerEventDuringHandle(string $eventName): void
{
$eventTriggered = false;

$app = $this->statelessApplication();

$app->on(
$eventName,
static function () use (&$eventTriggered): void {
$eventTriggered = true;
},
);

$app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());

self::assertTrue($eventTriggered, "Should trigger '{$eventName}' event during handle()");
}
}
Loading