Skip to content

test(http): Move testRenderExceptionSetsDisplayErrorsInDebugMode from ApplicationTest to ApplicationErrorHandlerTest for better organization. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

test(http): Move testRenderExceptionSetsDisplayErrorsInDebugMode from ApplicationTest to ApplicationErrorHandlerTest for better organization. #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e77401
test(http): Move `testRenderExceptionSetsDisplayErrorsInDebugMode` fr…
terabytesoftw Aug 25, 2025
29c4488
Apply fixes from StyleCI
terabytesoftw Aug 25, 2025
219a237
test(http): Enhance output buffer handling in `ApplicationErrorHandle…
terabytesoftw Aug 25, 2025
9369a4c
Apply fixes from StyleCI
terabytesoftw Aug 25, 2025
b67f777
test(http): Improve variable naming and refactor output buffer assert…
terabytesoftw Aug 25, 2025
3913cf4
refactor(http): Remove code coverage ignore comments in `ErrorHandler…
terabytesoftw Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/http/ErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,8 @@
$minLevel = YII_ENV_TEST ? 1 : 0;

while ($currentLevel > $minLevel) {
if (@ob_end_clean() === false) {

Check warning on line 88 in src/http/ErrorHandler.php

View workflow job for this annotation

GitHub Actions / mutation / PHP 8.3-ubuntu-latest 

Escaped Mutant for Mutator "Identical":

@@ @@
         $currentLevel = ob_get_level();
         $minLevel = YII_ENV_TEST ? 1 : 0;
         while ($currentLevel > $minLevel) {
-            if (@ob_end_clean() === false) {
+            if (@ob_end_clean() !== false) {
                 ob_clean();
             }
             $currentLevel = ob_get_level();

Check warning on line 88 in src/http/ErrorHandler.php

View workflow job for this annotation

GitHub Actions / mutation / PHP 8.3-ubuntu-latest 

Escaped Mutant for Mutator "Identical":

@@ @@
         $currentLevel = ob_get_level();
         $minLevel = YII_ENV_TEST ? 1 : 0;
         while ($currentLevel > $minLevel) {
-            if (@ob_end_clean() === false) {
+            if (@ob_end_clean() !== false) {
                 ob_clean();
             }
             $currentLevel = ob_get_level();
// @codeCoverageIgnoreStart
ob_clean();
// @codeCoverageIgnoreEnd
}

$currentLevel = ob_get_level();
Expand Down
74 changes: 74 additions & 0 deletions tests/http/stateless/ApplicationErrorHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,80 @@ static function ($errno, $errstr, $errfile, $errline) use (&$warningsCaptured):
}
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
#[RequiresPhpExtension('runkit7')]
public function testRenderExceptionSetsDisplayErrorsInDebugMode(): void
{
@\runkit_constant_redefine('YII_ENV_TEST', false);

$bufferBeforeLevel = ob_get_level();

$_SERVER = [
'REQUEST_METHOD' => 'GET',
'REQUEST_URI' => 'site/trigger-exception',
];

ob_start();
echo 'buffer content that should be cleared';
ob_start();
echo 'nested buffer content';

$originalDisplayErrors = ini_get('display_errors');

$app = $this->statelessApplication(
[
'components' => [
'errorHandler' => [
'discardExistingOutput' => true,
'errorAction' => null,
],
],
],
);

$response = $app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());

self::assertSame(
500,
$response->getStatusCode(),
"Expected HTTP '500' for route 'site/trigger-exception'.",
);
self::assertSame(
'text/html; charset=UTF-8',
$response->getHeaderLine('Content-Type'),
"Expected Content-Type 'text/html; charset=UTF-8' for route 'site/trigger-exception'.",
);
self::assertSame(
'1',
ini_get('display_errors'),
"'display_errors' should be set to '1' in debug mode when rendering exception.",
);

$bufferAfterLevel = ob_get_level();

self::assertLessThanOrEqual(
$bufferBeforeLevel,
$bufferAfterLevel,
"'clearOutput()' should properly clean output buffers",
);

while (ob_get_level() < $bufferBeforeLevel) {
ob_start();
}

self::assertSame(
$bufferBeforeLevel,
ob_get_level(),
'Output buffers should be restored to initial level.',
);

ini_set('display_errors', $originalDisplayErrors);

@\runkit_constant_redefine('YII_ENV_TEST', true);
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*
Expand Down
66 changes: 1 addition & 65 deletions tests/http/stateless/ApplicationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,11 @@

namespace yii2\extensions\psrbridge\tests\http\stateless;

use PHPUnit\Framework\Attributes\{Group, RequiresPhpExtension};
use PHPUnit\Framework\Attributes\{Group};
use yii\base\InvalidConfigException;
use yii2\extensions\psrbridge\tests\support\FactoryHelper;
use yii2\extensions\psrbridge\tests\TestCase;

use function ini_get;
use function ini_set;
use function ob_get_level;
use function ob_start;

#[Group('http')]
final class ApplicationTest extends TestCase
{
Expand All @@ -24,65 +19,6 @@ protected function tearDown(): void
parent::tearDown();
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
#[RequiresPhpExtension('runkit7')]
public function testRenderExceptionSetsDisplayErrorsInDebugMode(): void
{
@\runkit_constant_redefine('YII_ENV_TEST', false);

$initialBufferLevel = ob_get_level();

$_SERVER = [
'REQUEST_METHOD' => 'GET',
'REQUEST_URI' => 'site/trigger-exception',
];

$originalDisplayErrors = ini_get('display_errors');

try {
$app = $this->statelessApplication(
[
'components' => [
'errorHandler' => ['errorAction' => null],
],
],
);

$response = $app->handle(FactoryHelper::createServerRequestCreator()->createFromGlobals());

self::assertSame(
500,
$response->getStatusCode(),
"Expected HTTP '500' for route 'site/trigger-exception'.",
);
self::assertSame(
'text/html; charset=UTF-8',
$response->getHeaderLine('Content-Type'),
"Expected Content-Type 'text/html; charset=UTF-8' for route 'site/trigger-exception'.",
);
self::assertSame(
'1',
ini_get('display_errors'),
"'display_errors' should be set to '1' when YII_DEBUG mode is enabled and rendering exception view.",
);
self::assertStringContainsString(
'yii\base\Exception: Exception error message.',
$response->getBody()->getContents(),
'Response should contain exception details when YII_DEBUG mode is enabled.',
);
} finally {
ini_set('display_errors', $originalDisplayErrors);

while (ob_get_level() < $initialBufferLevel) {
ob_start();
}

@\runkit_constant_redefine('YII_ENV_TEST', true);
}
}

/**
* @throws InvalidConfigException if the configuration is invalid or incomplete.
*/
Expand Down
Loading