test(cookies): Add test for returning multiple validated cookies when validation is enabled.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Tests
  • Added a test to verify correct validation and retrieval of multiple signed cookies in requests when cookie validation is enabled.

[coderabbitai]

Walkthrough

A new test method was added to the PSR7RequestTest class to verify that multiple cookies are correctly validated and retrieved when cookie validation is enabled. The test simulates a PSR-7 request with several signed cookies, checks their validation, and asserts correct retrieval and values.

Changes

File(s)	Change Summary
tests/http/PSR7RequestTest.php	Added a test method to verify retrieval and validation of multiple signed cookies in a PSR-7 request.

Sequence Diagram(s)

sequenceDiagram
    participant Test as testReturnMultipleValidatedCookiesWhenValidationEnabledWithMultipleValidCookies
    participant App as Web Application Mock
    participant Security as Security Component
    participant Request as PSR-7 Request
    participant CookieCollection as Cookie Collection

    Test->>App: Set up environment and validation key
    Test->>Security: Sign multiple cookies
    Test->>Request: Create PSR-7 request with signed cookies
    Test->>Request: Enable cookie validation
    Test->>Request: Set PSR-7 request
    Test->>CookieCollection: Retrieve cookies
    Test->>Test: Assert cookies count, names, and values

Loading

Possibly related PRs

• test(adapter): Add test for retrieving cookie with correct name property when adapter is set. #13: Both PRs add new test methods to the PSR7RequestTest class focusing on cookie retrieval and validation behavior, with the main PR extending validation to multiple signed cookies while the retrieved PR tests correct cookie name property retrieval without validation.

Poem

Four cookies signed, a test to see,
If validation sets them free.
Each name and value, checked with care,
In PSR-7's cookie lair.
Rabbits cheer with every bite,
For cookies tested, all is right! 🍪🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2fe2c3 and 322294d.

📒 Files selected for processing (1)

• tests/http/PSR7RequestTest.php (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.300Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods, so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.300Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods (lines 28 and 32), so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1564-1578
Timestamp: 2025-07-20T16:33:57.457Z
Learning: The TestCase class in yii2-extensions/psr-bridge automatically handles $_SERVER superglobal cleanup by saving its original state before each test and restoring it afterward in setUp() and tearDown() methods. Manual $_SERVER cleanup in individual test methods is unnecessary when extending this TestCase.

tests/http/PSR7RequestTest.php (3)

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.300Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods (lines 28 and 32), so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1564-1578
Timestamp: 2025-07-20T16:33:57.457Z
Learning: The TestCase class in yii2-extensions/psr-bridge automatically handles $_SERVER superglobal cleanup by saving its original state before each test and restoring it afterward in setUp() and tearDown() methods. Manual $_SERVER cleanup in individual test methods is unnecessary when extending this TestCase.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.300Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods, so individual test methods that extend TestCase don't need manual $_SERVER restoration.

🪛 Gitleaks (8.27.2)

tests/http/PSR7RequestTest.php

668-668: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

🔇 Additional comments (1)

tests/http/PSR7RequestTest.php (1)

664-733: Excellent test implementation for multiple validated cookies!

This test properly verifies that multiple signed cookies are correctly validated and retrieved when cookie validation is enabled. The test structure is well-organized:

1. Creates multiple cookies with distinct values
2. Properly signs each cookie using Yii's security component
3. Verifies all cookies are present and correctly decrypted
4. Includes additional verification of cookie names

The implementation follows existing patterns in the file and provides comprehensive coverage for this important functionality.

Note: The static analysis warning about a "Generic API Key" on line 668 is a false positive - this is clearly a test validation key string used for cookie signing in the test environment.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b2fe2c3) to head (322294d).

Additional details and impacted files

@@             Coverage Diff             @@
##                main       #15   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        99        99           
===========================================
  Files              6         6           
  Lines            252       252           
===========================================
  Hits             252       252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.