refactor(http): Remove error handler unregistration from StatelessApplication constructor for cleaner initialization.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling continuity during application resets. The error handler is no longer unregistered during reset, preventing gaps in error reporting and ensuring consistent responses after a reset. This delivers more predictable behavior when recovering from errors or reinitializing the application.

[coderabbitai]

Walkthrough

Removed explicit error handler unregistration within StatelessApplication::reset. The reset flow otherwise remains: reinitialize parent, clear request-related state, rebind PSR-7 request, sync cookie validation, manage session lifecycle, and bootstrap. Error handler state is affected only via setResponse; unregister() is no longer invoked during reset.

Changes

Cohort / File(s)	Summary
Stateless reset behavior src/http/StatelessApplication.php	Deleted the conditional block that unregistered the error handler in reset(); retained the rest of the reset sequence (parent reinit, request/cookie/session handling, bootstrap).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant App as StatelessApplication
  participant EH as ErrorHandler
  participant Req as Request/Session/Cookies

  rect rgb(245,245,255)
  note over Caller,App: Old reset() flow (before this change)
  Caller->>App: reset()
  App->>EH: unregister()  %% Removed in new flow
  App->>App: parent::__construct(...)
  App->>Req: reset request state
  App->>Req: rebind PSR-7 request
  App->>Req: sync cookie validation
  App->>Req: manage session lifecycle
  App->>App: bootstrap()
  end

Loading

sequenceDiagram
  autonumber
  actor Caller
  participant App as StatelessApplication
  participant EH as ErrorHandler
  participant Req as Request/Session/Cookies

  rect rgb(240,255,240)
  note over Caller,App: New reset() flow (after this change)
  Caller->>App: reset()
  note over EH: No explicit unregister() call
  App->>App: parent::__construct(...)
  App->>Req: reset request state
  App->>Req: rebind PSR-7 request
  App->>Req: sync cookie validation
  App->>Req: manage session lifecycle
  App->>App: bootstrap()
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor(application): Improve response handling and reset request state in StatelessApplication. #89: Also adjusts StatelessApplication::reset and surrounding lifecycle; complements this change by modifying request reset and error-handler interactions.

Poem

A hop, a skip, reset anew—
I nudge no handler out of view.
Requests realign, cookies comply,
Sessions wake with a gentle sigh.
Bootstrap hums its steady tune—
I twitch my ears: “We’ll run soon!” 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a02b3cd and 9f8ac93.

📒 Files selected for processing (1)

• src/http/StatelessApplication.php (0 hunks)

💤 Files with no reviewable changes (1)

• src/http/StatelessApplication.php

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-mini-138

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a02b3cd) to head (9f8ac93).
⚠️ Report is 1 commits behind head on main.
⚠️ Test Analytics upload error: File not in storage

Additional details and impacted files

@@             Coverage Diff             @@
##                main      #157   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       318       317    -1     
===========================================
  Files             12        12           
  Lines            805       803    -2     
===========================================
- Hits             805       803    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[terabytesoftw]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.