feat(StatelessApplicationTest): Add test for rendering exceptions in RAW format with appropriate assertions.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Tests
  • Updated a test case to use "apache2handler" instead of "apache" as the input parameter.
  • Added a new test to verify that exceptions are rendered as plain text (without HTML tags) when using the RAW response format.
  • Improved test cleanup to reset HTTP function stubs after each test.

[coderabbitai]

Walkthrough

A test input value in ErrorHandlerTest was updated from 'apache' to 'apache2handler'. In StatelessApplicationTest, a new test method was introduced to verify exception rendering in raw format under the 'apache2handler' SAPI, and the tearDown method was enhanced to reset HTTP function stubs.

Changes

Cohort / File(s)	Change Summary
ErrorHandlerTest SAPI Input Update tests/http/ErrorHandlerTest.php	Changed test annotation input from 'apache' to 'apache2handler' for the relevant test method.
StatelessApplicationTest Enhancements tests/http/StatelessApplicationTest.php	Added a new test for raw exception rendering with 'apache2handler' SAPI; updated tearDown to reset HTTP stubs.

Sequence Diagram(s)

sequenceDiagram
    participant Test as testRenderExceptionWithRawFormat
    participant SAPIStub as SAPI Stub Utility
    participant App as Application
    participant ErrorHandler as ErrorHandler
    participant Response as Response

    Test->>SAPIStub: Set SAPI to 'apache2handler'
    Test->>App: Simulate GET /site/trigger-exception
    App->>ErrorHandler: Handle exception
    ErrorHandler->>Response: Render exception in RAW format
    Test->>Response: Assert status 500, plain text, no HTML tags
    Test->>SAPIStub: Reset HTTP stubs (tearDown)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• refactor(ErrorHandler): replace PHP_SAPI with php_sapi_name for consistency in SAPI tests. #59: Modifies the same test method in ErrorHandlerTest.php and adds a tearDown() for HTTP stub reset, both related to SAPI value handling in tests.
• refactor(tests): Improve exception documentation in StatelessApplicationTest class and add test for error handling during request processing. #42: Adds new tests in StatelessApplicationTest, focusing on different error handling scenarios, overlapping in test class but not in specific functionality.

Poem

In the warren of code, a test was reborn,
'apache' now 'apache2handler'—a new dawn!
With RAW exception checks, the bugs are outdone,
No HTML tags, just plain text fun.
🐇 The review is light—let's hop along,
For code and correctness, we all belong!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b19ec96 and de22ddb.

📒 Files selected for processing (2)

• tests/http/ErrorHandlerTest.php (1 hunks)
• tests/http/StatelessApplicationTest.php (3 hunks)

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#53
File: src/http/ErrorHandler.php:258-272
Timestamp: 2025-08-03T16:24:09.241Z
Learning: In yii2-extensions/psr-bridge, the StatelessApplication creates a new Response instance for each request in the reset() method, then passes it to ErrorHandler::setResponse(). This means the template response is not shared across requests, so calling clear() on it in createErrorResponse() is safe and doesn't cause side effects.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#53
File: src/http/ErrorHandler.php:258-272
Timestamp: 2025-08-03T16:24:09.241Z
Learning: In yii2-extensions/psr-bridge, the StatelessApplication creates a new Response instance for each request in the reset() method, then passes it to ErrorHandler::setResponse(). This means the template response is not shared across requests, so calling clear() on it in createErrorResponse() is safe and doesn't cause side effects.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.341Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods, so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.341Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods (lines 28 and 32), so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#53
File: src/http/ErrorHandler.php:258-272
Timestamp: 2025-08-03T16:24:09.241Z
Learning: In yii2-extensions/psr-bridge, the StatelessApplication creates a new Response instance for each request in the reset() method (line 408: `$this->response = new Response($this->components['response'] ?? []);`), then passes it to ErrorHandler::setResponse(). This means the template response is not shared across requests, so calling clear() on it in createErrorResponse() is safe and doesn't cause side effects.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1564-1578
Timestamp: 2025-07-20T16:33:57.495Z
Learning: The TestCase class in yii2-extensions/psr-bridge automatically handles $_SERVER superglobal cleanup by saving its original state before each test and restoring it afterward in setUp() and tearDown() methods. Manual $_SERVER cleanup in individual test methods is unnecessary when extending this TestCase.

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#21
File: tests/http/PSR7ResponseTest.php:0-0
Timestamp: 2025-07-22T00:50:26.546Z
Learning: In yii2-extensions/psr-bridge, the ResponseAdapter::formatCookieHeader() method uses `$expire !== 1` to skip validation for Yii2's special deletion cookies, but this should be extended to handle all expired cookies, not just the special case where expire=1.

📚 Learning: in yii2-extensions/psr-bridge, the statelessapplication creates a new response instance for each req...

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#53
File: src/http/ErrorHandler.php:258-272
Timestamp: 2025-08-03T16:24:09.241Z
Learning: In yii2-extensions/psr-bridge, the StatelessApplication creates a new Response instance for each request in the reset() method, then passes it to ErrorHandler::setResponse(). This means the template response is not shared across requests, so calling clear() on it in createErrorResponse() is safe and doesn't cause side effects.

Applied to files:

• tests/http/StatelessApplicationTest.php

📚 Learning: in yii2-extensions/psr-bridge, the statelessapplication creates a new response instance for each req...

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#53
File: src/http/ErrorHandler.php:258-272
Timestamp: 2025-08-03T16:24:09.241Z
Learning: In yii2-extensions/psr-bridge, the StatelessApplication creates a new Response instance for each request in the reset() method (line 408: `$this->response = new Response($this->components['response'] ?? []);`), then passes it to ErrorHandler::setResponse(). This means the template response is not shared across requests, so calling clear() on it in createErrorResponse() is safe and doesn't cause side effects.

Applied to files:

• tests/http/StatelessApplicationTest.php

📚 Learning: in the yii2-extensions/psr-bridge project, the base testcase class already handles $_server cleanup ...

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.341Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods, so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Applied to files:

• tests/http/StatelessApplicationTest.php

📚 Learning: in the yii2-extensions/psr-bridge project, the base testcase class already handles $_server cleanup ...

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1536-1552
Timestamp: 2025-07-20T16:35:15.341Z
Learning: In the yii2-extensions/psr-bridge project, the base TestCase class already handles $_SERVER cleanup in setUp() and tearDown() methods (lines 28 and 32), so individual test methods that extend TestCase don't need manual $_SERVER restoration.

Applied to files:

• tests/http/StatelessApplicationTest.php

📚 Learning: the testcase class in yii2-extensions/psr-bridge automatically handles $_server superglobal cleanup ...

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#6
File: tests/http/RequestTest.php:1564-1578
Timestamp: 2025-07-20T16:33:57.495Z
Learning: The TestCase class in yii2-extensions/psr-bridge automatically handles $_SERVER superglobal cleanup by saving its original state before each test and restoring it afterward in setUp() and tearDown() methods. Manual $_SERVER cleanup in individual test methods is unnecessary when extending this TestCase.

Applied to files:

• tests/http/StatelessApplicationTest.php

📚 Learning: in yii2-extensions/psr-bridge, the responseadapter::formatcookieheader() method uses `$expire !== 1`...

Learnt from: terabytesoftw
PR: yii2-extensions/psr-bridge#21
File: tests/http/PSR7ResponseTest.php:0-0
Timestamp: 2025-07-22T00:50:26.546Z
Learning: In yii2-extensions/psr-bridge, the ResponseAdapter::formatCookieHeader() method uses `$expire !== 1` to skip validation for Yii2's special deletion cookies, but this should be extended to handle all expired cookies, not just the special case where expire=1.

Applied to files:

• tests/http/StatelessApplicationTest.php

🧬 Code Graph Analysis (1)

tests/http/StatelessApplicationTest.php (2)

tests/support/stub/HTTPFunctions.php (2)

• HTTPFunctions (37-209)
• set_sapi (187-190)

tests/TestCase.php (1)

• statelessApplication (106-171)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: phpunit / PHP 8.2-windows-latest
• GitHub Check: mutation / PHP 8.3-ubuntu-latest
• GitHub Check: mutation / PHP 8.3-ubuntu-latest

🔇 Additional comments (4)

tests/http/ErrorHandlerTest.php (1)

109-109: LGTM! Consistent SAPI name across test suite.

The change from 'apache' to 'apache2handler' aligns with the new test in StatelessApplicationTest.php that specifically uses the apache2handler SAPI for testing exception rendering in RAW format.

tests/http/StatelessApplicationTest.php (3)

22-22: LGTM! Import added for new test functionality.

The HTTPFunctions import is appropriately added to support the new test method that uses SAPI stubbing.

---

54-54: LGTM! Proper cleanup after HTTP function stubbing.

Adding HTTPFunctions::reset() to the tearDown method ensures that HTTP function stubs are properly reset after each test, preventing test interference. This follows the same pattern used in ErrorHandlerTest.php.

---

730-779: LGTM! Comprehensive test for RAW format exception rendering.

The new test method effectively verifies exception rendering behavior in RAW format under the apache2handler SAPI. The test:

1. Properly configures the SAPI environment using the stub
2. Sets up the application with RAW format response and disabled error action
3. Triggers an exception through the site/trigger-exception route
4. Verifies the correct HTTP 500 status code
5. Asserts that the response body contains the expected exception class name and message
6. Importantly validates that no HTML tags (<pre>) are present in RAW format output

The assertions are well-designed and align perfectly with the PR objective of testing RAW format exception rendering with appropriate assertions.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_mini_47

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.46%. Comparing base (b19ec96) to head (de22ddb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main      #60      +/-   ##
============================================
+ Coverage     99.32%   99.46%   +0.13%     
  Complexity      292      292              
============================================
  Files            12       12              
  Lines           746      746              
============================================
+ Hits            741      742       +1     
+ Misses            5        4       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.