refactor(tests): Enhance HTTPFunctions to track http_response_code() calls and add test for exception handling in CLI SAPI.

src/http/ErrorHandler.php

@@ -14,7 +14,6 @@
 use function array_diff_key;
 use function array_flip;
 use function htmlspecialchars;
-use function http_response_code;
 use function ini_set;
 
 /**
@@ -117,23 +116,19 @@
     {
         $this->exception = $exception;
 
         $this->unregister();
 
         if (php_sapi_name() !== 'cli') {
-            $statusCode = 500;
-
-            if ($exception instanceof HttpException) {
-                $statusCode = $exception->statusCode;
-            }
+            $statusCode = $exception instanceof HttpException ? $exception->statusCode : 500;
 
             http_response_code($statusCode);
         }
 
         try {
             $this->logException($exception);
 
             if ($this->discardExistingOutput) {
                 $this->clearOutput();
             }
 
             $response = $this->renderException($exception);
@@ -185,11 +180,11 @@
         $response->data = 'An internal server error occurred.';
 
         if (YII_DEBUG) {
             $response->data = '<pre>' . htmlspecialchars($msg, ENT_QUOTES, Yii::$app->charset) . '</pre>';
             $safeServerVars = array_diff_key(
                 $_SERVER,
                 array_flip(
                     [
                         'API_KEY',
                         'AUTH_TOKEN',
                         'DB_PASSWORD',
@@ -197,7 +192,7 @@
                     ],
                 ),
             );
             $response->data .= "\n\$_SERVER = " . VarDumper::export($safeServerVars);
         }
 
         return $response;

tests/http/ErrorHandlerTest.php

@@ -68,6 +68,64 @@ public function testClearOutputCleansAllBuffersInNonTestEnvironment(): void
         }
     }
 
+    public function testHandleExceptionCallsHttpResponseCodeInNonCliSapi(): void
+    {
+        HTTPFunctions::set_sapi('apache2handler');
+
+        $errorHandler = new ErrorHandler();
+
+        $errorHandler->discardExistingOutput = false;
+
+        $exception = new Exception('Test exception for non-CLI SAPI');
+
+        $response = $errorHandler->handleException($exception);
+
+        self::assertSame(
+            'apache2handler',
+            HTTPFunctions::php_sapi_name(),
+            "Should return 'apache2handler' as the SAPI name when running in non-CLI environment.",
+        );
+        self::assertSame(
+            1,
+            HTTPFunctions::getHttpResponseCodeCalls(),
+            "Should call 'http_response_code()' exactly once in non-CLI SAPI; call count must be '1'.",
+        );
+        self::assertSame(
+            500,
+            $response->getStatusCode(),
+            "Should set status code to '500' for Exception in non-CLI SAPI.",
+        );
+    }
+
+    public function testHandleExceptionDoesNotCallHttpResponseCodeInCliSapi(): void
+    {
+        HTTPFunctions::set_sapi('cli');
+
+        $errorHandler = new ErrorHandler();
+
+        $errorHandler->discardExistingOutput = false;
+
+        $exception = new Exception('Test exception for CLI SAPI');
+
+        $response = $errorHandler->handleException($exception);
+
+        self::assertSame(
+            'cli',
+            HTTPFunctions::php_sapi_name(),
+            "Should return 'cli' as the SAPI name when running in CLI environment.",
+        );
+        self::assertSame(
+            0,
+            HTTPFunctions::getHttpResponseCodeCalls(),
+            "Should not call 'http_response_code()' in CLI SAPI; call count must remain '0'.",
+        );
+        self::assertSame(
+            500,
+            $response->getStatusCode(),
+            "Should set status code to '500' for Exception in CLI SAPI.",
+        );
+    }
+
     public function testHandleExceptionResetsState(): void
     {
         $errorHandler = new ErrorHandler();

tests/support/MockerExtension.php

@@ -73,6 +73,13 @@ public static function load(): void
                     $line,
                 ),
             ],
+            [
+                'namespace' => 'yii2\extensions\psrbridge\http',
+                'name' => 'http_response_code',
+                'function' => static fn(int|null $response_code = null): int => HTTPFunctions::http_response_code(
+                    $response_code,
+                ),
+            ],
             [
                 'namespace' => 'yii2\extensions\psrbridge\http',
                 'name' => 'php_sapi_name',

tests/support/stub/HTTPFunctions.php

@@ -63,6 +63,11 @@ final class HTTPFunctions
      */
     private static int $headersSentLine = 0;
 
+    /**
+     * Tracks the number of times {@see \http_response_code()} was called.
+     */
+    private static int $httpResponseCodeCalls = 0;
+
     /**
      * Tracks the HTTP response code.
      */
@@ -96,6 +101,11 @@ public static function getHeader(string $header): array
         return self::$headers[strtolower($header)] ?? [];
     }
 
+    public static function getHttpResponseCodeCalls(): int
+    {
+        return self::$httpResponseCodeCalls;
+    }
+
     public static function hasHeader(string $header): bool
     {
         return array_key_exists(strtolower($header), self::$headers);
@@ -153,6 +163,8 @@ public static function headers_sent(mixed &$file = null, mixed &$line = null): b
 
     public static function http_response_code(int|null $response_code = 0): int
     {
+        self::$httpResponseCodeCalls++;
+
         if ($response_code > 0) {
             self::$responseCode = $response_code;
         }
@@ -172,6 +184,7 @@ public static function reset(): void
         self::$headersSent = false;
         self::$headersSentFile = '';
         self::$headersSentLine = 0;
+        self::$httpResponseCodeCalls = 0;
         self::$responseCode = 200;
         self::$sapi = 'cli';
         self::$streamGetContentsShouldFail = false;