Merge 6fcf924 into 428b63d

Author: terabytesoftw

.github/workflows/bc.yml

@@ -1,15 +1,14 @@
 on:
-  pull_request:
-  push:
+  - pull_request
+  - push
 
 name: backwards compatibility
+
 jobs:
   roave_bc_check:
-    name: Roave BC Check
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@master
-      - name: fetch tags
-        run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
-      - name: Roave BC Check
-        uses: docker://nyholm/roave-bc-check-ga
+    uses: yiisoft/actions/.github/workflows/bc.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

.github/workflows/rector.yml

@@ -18,4 +18,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.0']
+        ['8.1']

composer.json

@@ -34,7 +34,7 @@
     "require-dev": {
         "maglnet/composer-require-checker": "^4.4",
         "phpunit/phpunit": "^9.5",
-        "rector/rector": "^0.15.4",
+        "rector/rector": "^0.16",
         "roave/infection-static-analysis-plugin": "^1.25",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.30|^5.4"

tests/ArrayHelper/GetValueTest.php

@@ -8,6 +8,7 @@
 use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
 use stdClass;
+use Throwable;
 use Yiisoft\Arrays\ArrayHelper;
 use Yiisoft\Arrays\Tests\Objects\Magic;
 use Yiisoft\Arrays\Tests\Objects\Post1;
@@ -221,19 +222,25 @@ public function testGetNestedValueFromObjectFromArray(): void
      */
     public function testGetValueNonexistingProperties1(): void
     {
-        $this->expectError();
-        $object = new Post1();
-        $this->assertNull(ArrayHelper::getValue($object, 'nonExisting'));
+        try {
+            $object = new Post1();
+            ArrayHelper::getValue($object, 'nonExisting');
+        } catch (Throwable $e) {
+            $this->assertSame('Undefined property: Yiisoft\Arrays\Tests\Objects\Post1::$nonExisting', $e->getMessage());
+        }
     }
 
     /**
      * This is expected to result in a PHP error.
      */
     public function testGetValueNonexistingProperties2(): void
     {
-        $this->expectError();
-        $arrayObject = new ArrayObject(['id' => 23], ArrayObject::ARRAY_AS_PROPS);
-        $this->assertEquals(23, ArrayHelper::getValue($arrayObject, 'nonExisting'));
+        try {
+            $arrayObject = new ArrayObject(['id' => 23], ArrayObject::ARRAY_AS_PROPS);
+            ArrayHelper::getValue($arrayObject, 'nonExisting');
+        } catch (Throwable $e) {
+            $this->assertSame('Undefined array key "nonExisting"', $e->getMessage());
+        }
     }
 
     public function testGetValueFromStaticProperty(): void
@@ -246,12 +253,12 @@ public function testGetValueFromStaticProperty(): void
     public function testGetUndefinedPropertyFromObject(): void
     {
         $object = new stdClass();
-        if (PHP_VERSION_ID >= 80000) {
-            $this->expectWarning();
-        } else {
-            $this->expectNotice();
+
+        try {
+            ArrayHelper::getValue($object, 'var');
+        } catch (Throwable $e) {
+            $this->assertSame('Undefined property: stdClass::$var', $e->getMessage());
         }
-        ArrayHelper::getValue($object, 'var');
     }
 
     public function testExistingMagicObjectProperty(): void