FR: ArrayHelper::index, remove key from array

[alex-code]

Would this be useful? A 4th option for ArrayHelper::index which specifies the key should be removed from the array.
Helps avoid some duplication of data. I can do PR and tests if it's likely to be used.

$array = [
  ['id' => '123', 'data' => 'abc', 'device' => 'laptop'],
  ['id' => '345', 'data' => 'def', 'device' => 'tablet'],
  ['id' => '345', 'data' => 'hgi', 'device' => 'smartphone'],
];

$result = ArrayHelper::index($array, 'id');
[
 '123' => ['id' => '123', 'data' => 'abc', 'device' => 'laptop'],
 '345' => ['id' => '345', 'data' => 'hgi', 'device' => 'smartphone']
]

$result = ArrayHelper::index($array, 'id', [], true);
[
  '123' => ['data' => 'abc', 'device' => 'laptop'],
  '345' => ['data' => 'hgi', 'device' => 'smartphone']
]

[samdark]

Yes. It can be useful but another argument can't be added without breaking backwards compatibility.

[alex-code]

This was how I was planning to do it.

public static function index($array, $key, $groups = [], $removeKey = false)

Then it's used like,

ArrayHelper::index($array, 'key', [], true);

I'm not sure if it would be usable with groups so could make the $groups param dual purpose?

[samdark]

No. Making it dual purpose is a bad idea.

[np25071984]

It isn't possible until we have anonymous function in param list. User can do it inside the anonymous function, but we can't be sure he will do it.

// in this case we should pass $array param by reference in getValue method
// public static function getValue(&$array, $key, $default = null);
$result = ArrayHelper::index($array, function ($element) {
    $tmp = $element['id'];
    unset($element['id']);
    return $tmp;
});

As result I think better way is to leave key values within the result array.

[samdark]

See #94