Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 19, 2025

Q A
Is bugfix?
New feature?
Breaks BC?

Related to yiisoft/db#1098

@vjik vjik mentioned this pull request Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.00%. Comparing base (e6fe986) to head (9c1befd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #379   +/-   ##
=========================================
  Coverage     98.00%   98.00%           
  Complexity      242      242           
=========================================
  Files            26       26           
  Lines           803      803           
=========================================
  Hits            787      787           
  Misses           16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team November 19, 2025 13:38
@vjik vjik added the status:code review The pull request needs review. label Nov 19, 2025

$db = $this->getConnection(true);
$this->loadFixture(
__DIR__ . '/Support/Fixture/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use default directory and pass only file name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixtureDump with constants is added.

@vjik vjik requested a review from Tigrov November 20, 2025 12:54
@vjik vjik merged commit 90e8248 into master Nov 20, 2025
19 of 20 checks passed
@vjik vjik deleted the refactor-test branch November 20, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants