-
-
Notifications
You must be signed in to change notification settings - Fork 13
PHP 8.5 support #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.5 support #385
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
=========================================
Coverage 97.82% 97.82%
Complexity 250 250
=========================================
Files 26 26
Lines 827 827
=========================================
Hits 809 809
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds PHP 8.5 support to the yiisoft/db-oracle package. The changes modernize the dependency management by adopting bamarni/composer-bin-plugin to isolate development tools (psalm and infection) into separate composer.json files under a tools/ directory, preventing dependency conflicts. The PHP version constraint is updated from 8.1 - 8.4 to 8.1 - 8.5 across all relevant files.
Key changes:
- Updated PHP version constraint to support PHP 8.5
- Adopted bamarni/composer-bin-plugin for isolated tool dependency management
- Updated CI workflows to test against PHP 8.5 and maintain backward compatibility testing
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP constraint to 8.1-8.5, added bamarni/composer-bin-plugin, removed vimeo/psalm and roave/infection-static-analysis-plugin from main dependencies |
| tools/psalm/composer.json | New file defining psalm as an isolated tool dependency |
| tools/infection/composer.json | New file defining infection as an isolated tool dependency |
| tools/.gitignore | Ignores vendor and composer.lock for tool directories |
| README.md | Added Requirements section documenting PHP 8.1-8.5 support |
| CHANGELOG.md | Updated entry #306 to reference both #306 and #385 for PHP version change |
| .github/workflows/rector.yml | Updated to use PHP 8.5 for rector checks |
| .github/workflows/mutation.yml | Updated matrix to PHP 8.5 and added composer install step |
| .github/workflows/composer-require-checker.yml | Added PHP 8.5 to test matrix |
| .github/workflows/build.yml | Updated matrix to test PHP 8.5 with Oracle 18 & 21, added PHP 8.4 compatibility test |
Comments suppressed due to low confidence (1)
.github/workflows/mutation.yml:80
- The workflow references
roave-infection-static-analysis-pluginwhich was removed from composer.json dependencies. This command will fail. Update to use the appropriate infection command from tools/infection, such ascomposer bin infection exec infectionor adjust the workflow to use the tool installed via bamarni/composer-bin-plugin.
vendor/bin/roave-infection-static-analysis-plugin --threads=2 --ignore-msi-with-no-mutations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related to yiisoft/db#1113