Skip to content

Conversation

@DAGpro
Copy link
Contributor

@DAGpro DAGpro commented Apr 14, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️/❌
Fixed issues

@DAGpro
Copy link
Contributor Author

DAGpro commented Apr 14, 2025

IDE played with formatting Yaml and Composer Files I hope this is not critical 😅

@DAGpro
Copy link
Contributor Author

DAGpro commented Apr 14, 2025

Inspired by the ideas of corrections from this pr yiisoft/view#280

@samdark samdark requested a review from vjik April 14, 2025 11:48
DAGpro and others added 2 commits April 14, 2025 20:47
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@samdark
Copy link
Member

samdark commented Apr 15, 2025

@DAGpro
Copy link
Contributor Author

DAGpro commented Apr 15, 2025

https://pecl.php.net/package/uopz/7.1.1/windows

Pecl doesn't have a version for PHP 8.4 yet.
Lower PHP requirements?

@vjik
Copy link
Member

vjik commented Apr 16, 2025

https://pecl.php.net/package/uopz/7.1.1/windows

Pecl doesn't have a version for PHP 8.4 yet. Lower PHP requirements?

It needs to try remove uopz extension usage. Seems, after yiisoft/cookies#72 it can be done.

@DAGpro
Copy link
Contributor Author

DAGpro commented Apr 17, 2025

https://pecl.php.net/package/uopz/7.1.1/windows
У Pecl пока нет версии для PHP 8.4. Снижение требований к PHP?

Нужно попробовать удалить использование расширения uopz. Кажется, после yiisoft/cookies#72 это можно сделать.

private function saveLocale(string $locale, ResponseInterface $response): ResponseInterface
{
    if ($this->cookieDuration === null) {
        return $response;
    }

    $this->logger->debug('Saving found locale to cookies.');
    $cookie = new Cookie(name: $this->cookieName, value: $locale, secure: $this->secureCookie);
    $cookie = $cookie->withMaxAge($this->cookieDuration);

    return $cookie->addToResponse($response);
}

Add psr/clock and clock-implementation to dependencies or implement the class in the package and pass it to the cookie class?

@vjik
Copy link
Member

vjik commented Apr 17, 2025

I did it: #130

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6a99980) to head (1167976).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #129   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       136       138    +2     
===========================================
  Files             11        11           
  Lines            360       366    +6     
===========================================
+ Hits             360       366    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
@samdark samdark merged commit 212bc21 into yiisoft:master Apr 19, 2025
17 of 19 checks passed
@samdark
Copy link
Member

samdark commented Apr 19, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants