-
-
Notifications
You must be signed in to change notification settings - Fork 8
PHP 8.4 support #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 support #129
Conversation
DAGpro
commented
Apr 14, 2025
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️/❌ |
| Fixed issues |
|
IDE played with formatting Yaml and Composer Files I hope this is not critical 😅 |
|
Inspired by the ideas of corrections from this pr yiisoft/view#280 |
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
|
https://pecl.php.net/package/uopz/7.1.1/windows Pecl doesn't have a version for PHP 8.4 yet. |
It needs to try remove uopz extension usage. Seems, after yiisoft/cookies#72 it can be done. |
Add psr/clock and clock-implementation to dependencies or implement the class in the package and pass it to the cookie class? |
|
I did it: #130 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 136 138 +2
===========================================
Files 11 11
Lines 360 366 +6
===========================================
+ Hits 360 366 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
|
Thank you! |