Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 support #4386

Merged
merged 18 commits into from
Jul 19, 2022
Merged

PHP 8.1 support #4386

merged 18 commits into from
Jul 19, 2022

Conversation

marcovtwout
Copy link
Member

@marcovtwout marcovtwout commented Dec 1, 2021

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #4385

List of issues:

Please list additional issues found in #4385

@kenguest
Copy link
Contributor

kenguest commented Dec 3, 2021

Support for PHP 8.1 would be great.
Currently seeing a lot of deprecation messages such as this:
Return type of CCache::offsetExists($id) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice (/var/www/myproject/vendor/yiisoft/yii/framework/caching/CCache.php:337

@marcovtwout marcovtwout mentioned this pull request Jan 18, 2022
@samdark samdark added this to the 1.1.26 milestone Jan 18, 2022
@marcovtwout marcovtwout mentioned this pull request Mar 10, 2022
Previous build failed on:

```
Run echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
  echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
  shell: /usr/bin/bash -e {0}
  env:
    extensions: curl, cubrid, mbstring, memcached, dom, intl, json, libxml, pdo, pdo_mysql, pdo_pgsql, pdo_sqlite, xml, xmlwriter, mcrypt
    key-php5: cache-v1
    key-php7: cache-v2
PHP Deprecated:  Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/composer/vendor/symfony/console/Helper/HelperSet.php on line 112
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/composer/src/Composer/Repository/ArrayRepository.php:206
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/composer/src/Composer/Repository/ArrayRepository.php:206
Deprecation Notice: Return type of Composer\Repository\ArrayRepository::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/composer/src/Composer/Repository/ArrayRepository.php:206
Error: Unable to process file command 'env' successfully.
Error: Invalid environment variable format 'Deprecated: Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/composer/vendor/symfony/console/Helper/HelperSet.php on line 112'
```
Patch reintegrated.
composer.json Outdated Show resolved Hide resolved
@marcovtwout marcovtwout changed the title [WIP] PHP 8.1 support PHP 8.1 support Apr 7, 2022
@mashb1t
Copy link

mashb1t commented Apr 29, 2022

@marcovtwout @samdark as the only checkbox left mentions ezyang/htmlpurifier#311, which was fixed by ezyang/htmlpurifier#310 but not closed, i assume this PR is not blocked anymore. It would be great if you could confirm and merge this PR so we can use Yii with PHP 8.1, thanks!

@marcovtwout
Copy link
Member Author

@mashb1t Still waiting on a tagged release for htmlpurifier (ezyang/htmlpurifier#311 (comment)), so I can then incorporate it into this PR and finish it.

@marcovtwout
Copy link
Member Author

Since there is no stable release for htmlpurifier with 8.1 support I created a manual build of the appropiate dev version. If someone would like to verify it works I will merge this PR!

@marcovtwout
Copy link
Member Author

There finally is a new tagged htmlpurifier release, I'll add that before next release.

@marcovtwout
Copy link
Member Author

marcovtwout commented Sep 28, 2022

Htmlpurifier 4.15.0 added to master: bcb461e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants