Implementation of aws SQS #134
Conversation
src/drivers/sqs/Command.php
Outdated
| use yii\queue\cli\Command as CliCommand; | ||
|
|
||
| /** | ||
| * Manages application gearman-queue. |
There was a problem hiding this comment.
This class is full copy of https://github.com/yiisoft/yii2-queue/blob/master/src/drivers/gearman/Command.php
src/drivers/sqs/Queue.php
Outdated
| return $this->_client; | ||
| } | ||
|
|
||
| private $_client; |
There was a problem hiding this comment.
properties should be declared before methods
| } | ||
|
|
||
| /** | ||
| * Set the visibilty to reserve message |
There was a problem hiding this comment.
Please, correct phpdoc of all methods.
src/drivers/sqs/Queue.php
Outdated
| */ | ||
| protected function getClient() | ||
| { | ||
| if ($this->key && $this->secret) |
There was a problem hiding this comment.
By PSR-2, open bracket should start in the same line.
| /** | ||
| * @inheritdoc | ||
| */ | ||
| protected function pushMessage($message, $ttr, $delay, $priority) |
src/drivers/sqs/Queue.php
Outdated
| $receiptHandle = $payload['ReceiptHandle']; | ||
| $this->getClient()->changeMessageVisibility(array( | ||
| 'QueueUrl' => $this->url, | ||
| 'ReceiptHandle' => $queue_handle, |
There was a problem hiding this comment.
probably this variable should be $receiptHandle ?
| */ | ||
| public function listen() | ||
| { | ||
| $this->run(); |
There was a problem hiding this comment.
I think this method should do the same as in other queue drivers. $queue->listen() should run an infinite loop with timeout (sleep) to use as a daemon, regardless of payload existence.
|
Hi, will be there any progress with this PR? |
|
suggest to base64_encode, and base64_decode for the MessageBody & Payload's Body, as SQS will throw error for PhpSerializer string, due to some characters are not allowed. |
|
@ryusoft , @elitemaks, Will review and update here accordingly. I am going to push this class in one of testing envoirment this week and if everything fine, will move it to production replacing db queue. |
|
Example of error messages: exception 'Aws\Sqs\Exception\SqsException' with message 'Error executing "SendMessage" on "https://sqs.xxx.amazonaws.com/xxxxxxxxx/qqq"; AWS HTTP error: Client error: I (truncated...)
|
| 'MessageBody' => "$ttr;$message", | ||
| ]); | ||
|
|
||
| if ($model !== null) { |
There was a problem hiding this comment.
if ($model === null) {
return false;
}
return $model['MessageId'];
| */ | ||
| private function release($payload) | ||
| { | ||
| if (!empty($payload['ReceiptHandle'])) { |
There was a problem hiding this comment.
if (empty($payload['ReceiptHandle'])) {
return false;
}
// rest of the code here
|
@manoj-malviya Hi, is there any progress? There are several requests for changes still pending. |
|
It seems that the author is not available. It would be a good improvement. |
|
I'd like to try, but not sure what is the best way to do it. Should I create a new PR or how it's possible to continue with the current? |
|
Yes. Create new one and merge commits from this one into it. |
|
Closed in favor of #192 |
7 participants
Basic implementation of aws SQS. So far implements 2 authentication methods
Directly embedding key/secret in config
if key and secret is not preset it will use Default CredensialProvider
see http://docs.aws.amazon.com/aws-sdk-php/v3/guide/guide/credentials.html#credential-profiles.
Please review and provide feedback.