Query each method does not recognize if there are no more rows

[aliechti]

Like mentioned in: #9962 there is a problem with the recognition of the end of a resultset.

Example:
There is a table with 10 entries

foreach ($query->each() as $key => $value) {
    echo $key."\n";
}

after it selects the 10th row it throws an exception:

Exception 'PDOException' with message 'SQLSTATE[IMSSP]:
There are no more rows in the active result set.
Since this result set is not scrollable, no more data may be retrieved.'

in vendor\yiisoft\yii2\db\DataReader.php:111

Stack trace:
#0 vendor\yiisoft\yii2\db\DataReader.php(111): PDOStatement->fetch()
#1 vendor\yiisoft\yii2\db\BatchQueryResult.php(143): yii\db\DataReader->read()
#2 vendor\yiisoft\yii2\db\BatchQueryResult.php(112): yii\db\BatchQueryResult->fetchData()
#3 commands\TestController.php(26): yii\db\BatchQueryResult->next()

[SilverFire]

As for me, it is not a feature - it's a bug, and it affects only MSSQL

[samdark]

@SilverFire feature:db means it's database related, not the fact that it's a feature :)

[jadrovski]

yea it's a bug, how to fix? :-(

[samdark]

https://bugs.php.net/bug.php?id=65945

[alexkart]

So, this can't be fixed in the framework code?
If so, there is a workaround:

$allRows = [];
try {
    foreach ($query->each() as $index => $row) {
        $allRows[$index] = $row;
    }
} catch (\PDOException $e) {
    if ($e->getMessage() !== 'SQLSTATE[IMSSP]: There are no more rows in the active result set.  Since this result set is not scrollable, no more data may be retrieved.') {
        throw $e;
    }
}

And it works correctly, $allRows will contain all rows. The same is true for batch().

[samdark]

So, this can't be fixed in the framework code?

Can't we add the above workaroud to each?

[alexkart]

So, this can't be fixed in the framework code?

Can't we add the above workaroud to each?

Yes, I've created a PR