Skip to content

Conversation

@nineinchnick
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e9fcde3 on nineinchnick:batch-insert into 337b1b0 on yiisoft:master.

@pmoust
Copy link
Contributor

pmoust commented Nov 24, 2013

Awesome, thank you.

@qiangxue
Copy link
Member

This is already supported through the base QueryBuilder class.

@qiangxue qiangxue closed this Nov 24, 2013
@pmoust
Copy link
Contributor

pmoust commented Nov 24, 2013

Please re-open. The base QueryBuilder class provides a batchInsert() method that is only for sqlite3 3.7.11 and upwards. It's too young to be adopted like that.
@nineinchnick 's implementation works for all versions.

@qiangxue qiangxue reopened this Nov 24, 2013
qiangxue added a commit that referenced this pull request Nov 24, 2013
support for batch insert in sqlite older than 3.7.11
@qiangxue qiangxue merged commit cf73f40 into yiisoft:master Nov 24, 2013
@qiangxue
Copy link
Member

ah, didn't notice the difference. Thanks.

@nineinchnick nineinchnick deleted the batch-insert branch November 24, 2013 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants