ActiveRecord::delete() refactoring #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the original code is fine. I also think we should not spend time in refactoring code in favor of preemptive return. It has both pros and cons. Refactoring may be needed only if there are too many returns in the code. |
Contributor
Author
|
@qiangxue We remove 1 level nesting here. Its important. |
Member
|
It's only important if the nested code is very long (and the rule is very vague here). I'm not saying your refactoring is worse, but it's not better either. |
|
Changes Unknown when pulling 64962c6 on creocoder:active-record-refactoring-2 into * on yiisoft:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed nesting