Enhancements to Formatter for parsing dates & numbers #5000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances `normalizeDateTimeValue` to return a DateTime object instead of a converted double value, that fails. The DateTime object input is supported by 32 bit, 64 bit, as well as the `IntlDateFormatter` to format all years. (including fixing of the Y2K38 bug). Fixes issue in #4989.
framework/i18n/Formatter.php
Outdated
Member
|
could you please adjust unit tests to verify it is working correctly? |
Contributor
Author
|
Tests are failing for arbitrary formats. Will check and update on this. |
Contributor
Author
|
Necessary changes done. All current tests are now running fine. |
kartik-v
changed the title
Member
|
Merged with some adjustments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of various enhancements incorporated:
normalizeDateTimeValuewill parse, convert, and return aDateTimeobject for seamless usage across 32 bit, 64 bit systems or using withinIntlDateFormatter.TheDateTimeobject is supported for input & output across date values by 32 bit, 64 bit, as well as theIntlDateFormatterto format all date strings (including fixing of the Y2K38 bug). Fixes issue in Formatter crashes with fatal error on invalid date. #4989.formatDateTimeValuewill now read aDateTimeobject from above method for formatting as needed.InvalidConfigExceptionhandling for date & time formatting to captureDateTimeparsing errors.asRelativeTimehas been changed to reflect usage ofDateTimeobjectasTimestamphas been changed to reflect usage ofDateTimeobjectnormalizeNumericValuenow parses empty strings and returns a zero - so no exception is thrown.