Skip to content

Conversation

@crtlib
Copy link
Contributor

@crtlib crtlib commented Aug 3, 2013

I know it's not life-threatening, but I think it's a bit more conventional

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8ba04a6 on crtlib:master into 9f4ccb6 on yiisoft:master.

@cebe
Copy link
Member

cebe commented Aug 3, 2013

Makes code less readable. We had discussion about that before, only use DIRECTORY_SEPARATOR when value might appear elsewhere for example in a config value, not in include or require.

Some references:
a6c251d#commitcomment-3291800
607f3a5#commitcomment-3335365

@cebe cebe closed this Aug 3, 2013
@ghost ghost assigned cebe Aug 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants