Projects: Better projects fetching #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Heavily modified how projects are fetched in specific use cases and fixed few bugs related to it.
Additional review information
Added new method
get_rest_projects_listwhich receivesname,codeactive,createdAtandupdatedAtdata for all projects.Modified
_get_project_graphql_fieldsto return what fetch types has to be done to collect all requested data. GraphQl fetching supports more fields likebundle,data,usedTags, etc. Use both GraphQl and rest only if it is necessary. Added few safe guards for fetched data, e.g."data"can beNoneandproductTypesmight not be in graphql project,Testing notes:
get_projects(fields={"name", "active", "data"})won't triggerget_rest_projects.get_projects(fields={"name", "active", "data", "config"})won't trigger_get_graphql_projects.get_projects(fields={"name", "active", "data", "config", "productTypes"})will trigger bothget_rest_projectsand_get_project_graphql_fields.