Installed package detection in symfony framework extension

Author: yann-eugone

composer.json

@@ -12,6 +12,7 @@
   ],
   "require": {
     "php": "^7.2",
+    "composer-runtime-api": "^2.0",
     "symfony/framework-bundle": "^4.4|^5.0",
     "yokai/batch": "self.version"
   },

src/DependencyInjection/Configuration.php

@@ -33,8 +33,10 @@ private function storage(): ArrayNodeDefinition
         $node = (new TreeBuilder('storage'))->getRootNode();
 
         $node
+            ->addDefaultsIfNotSet()
             ->children()
                 ->arrayNode('filesystem')
+                    ->addDefaultsIfNotSet()
                     ->children()
                         ->scalarNode('dir')
                             ->defaultValue('%kernel.project_dir%/var/batch')

src/DependencyInjection/YokaiBatchExtension.php

@@ -4,6 +4,7 @@
 
 namespace Yokai\Batch\Bridge\Symfony\Framework\DependencyInjection;
 
+use Composer\InstalledVersions;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Loader as ConfigLoader;
 use Symfony\Component\Console\Application;
@@ -34,15 +35,13 @@ public function load(array $configs, ContainerBuilder $container): void
 
         $loader = $this->getLoader($container);
         $loader->load('global/');
-        $bundles = $container->getParameter('kernel.bundles');
 
         $bridges = [
-            'doctrine/orm/' => isset($bundles['DoctrineBundle']),
-            'doctrine/mongodb/' => isset($bundles['DoctrineMongoDBBundle']),
-            'symfony/console/' => class_exists(Application::class),
-            'symfony/messenger/' => class_exists(MessageBusInterface::class),
-            'symfony/serializer/' => interface_exists(SerializerInterface::class),
-            'symfony/validator/' => interface_exists(ValidatorInterface::class),
+            'doctrine/orm/' => $this->installed('doctrine-orm'),
+            'symfony/console/' => $this->installed('symfony-console'),
+            'symfony/messenger/' => $this->installed('symfony-messenger'),
+            'symfony/serializer/' => $this->installed('symfony-serializer'),
+            'symfony/validator/' => $this->installed('symfony-validator'),
         ];
 
         foreach (array_keys(array_filter($bridges)) as $resource) {
@@ -60,6 +59,15 @@ public function load(array $configs, ContainerBuilder $container): void
         $container->setAlias(JobLauncherInterface::class, $launcher);
     }
 
+    private function installed(string $package): bool
+    {
+        if (InstalledVersions::isInstalled('yokai/batch-src')) {
+            return true;
+        }
+
+        return InstalledVersions::isInstalled('yokai/batch-' . $package);
+    }
+
     private function getLoader(ContainerBuilder $container): ConfigLoader\LoaderInterface
     {
         $locator = new FileLocator(__DIR__ . '/../Resources/services');
@@ -89,7 +97,7 @@ private function configureStorage(ContainerBuilder $container, array $config): v
             ;
 
             $defaultStorage = 'yokai_batch.storage.dbal';
-        } elseif (isset($config['filesystem'])) {
+        } else {
             $container
                 ->register('yokai_batch.storage.filesystem', FilesystemJobExecutionStorage::class)
                 ->setArguments(
@@ -101,8 +109,6 @@ private function configureStorage(ContainerBuilder $container, array $config): v
             ;
 
             $defaultStorage = 'yokai_batch.storage.filesystem';
-        } else {
-            throw new \LogicException();//todo
         }
 
         try {