pwm: add raspberry pi pico PWM driver #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yonatan Schachter <yonatan.schachter@gmail.com>
Signed-off-by: Yonatan Schachter <yonatan.schachter@gmail.com> Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Signed-off-by: Yonatan Schachter <yonatan.schachter@gmail.com>
Signed-off-by: Yonatan Schachter <yonatan.schachter@gmail.com>
Signed-off-by: Yonatan Schachter <yonatan.schachter@gmail.com>
Add rapsberry pi pico PWM driver. Signed-off-by: Radu Pirea <pirea.radu@gmail.com>
github-actions
bot
added
area: Boards
area: PWM
area: Devicetree
area: Devicetree Binding
labels
yonsch
pushed a commit
that referenced
this pull request
Aug 8, 2021
Implement the functions required to calculate the SubEvent 1 and SubEvent n mapped channel indices. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
yonsch
pushed a commit
that referenced
this pull request
Aug 8, 2021
Added Bluetooth Specification references to the implementation of Channel Selection algorithm #2 in the Controller. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
yonsch
force-pushed
the
support_raspberrypi_pico
branch
from
0bdba34 to
2f1955d
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
7 times, most recently
from
1aad670 to
f272057
Compare
yonsch
pushed a commit
that referenced
this pull request
Oct 23, 2021
Remove explicit disable of Channel Selection Algorithm #2 in the mesh tests that use Extended Advertising. Fixes zephyrproject-rtos#39188. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
yonsch
force-pushed
the
support_raspberrypi_pico
branch
from
f272057 to
a7de8d0
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
4 times, most recently
from
d7ef07c to
fa6a098
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
3 times, most recently
from
42b860f to
0fdb49d
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
from
0fdb49d to
3ed4d59
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
2 times, most recently
from
86d7ea3 to
314c4c4
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
4 times, most recently
from
2e9c80f to
a69989e
Compare
yonsch
force-pushed
the
support_raspberrypi_pico
branch
12 times, most recently
from
e441781 to
c93f206
Compare
yonsch
pushed a commit
that referenced
this pull request
Dec 8, 2022
This patch reworks how fragments are handled in the net_buf infrastructure. In particular, it removes the union around the node and frags members in the main net_buf structure. This is done so that both can be used at the same time, at a cost of 4 bytes per net_buf instance. This implies that the layout of net_buf instances changes whenever being inserted into a queue (fifo or lifo) or a linked list (slist). Until now, this is what happened when enqueueing a net_buf with frags in a queue or linked list: 1.1 Before enqueueing: +--------+ +--------+ +--------+ |#1 node|\ |#2 node|\ |#3 node|\ | | \ | | \ | | \ | frags |------| frags |------| frags |------NULL +--------+ +--------+ +--------+ net_buf #1 has 2 fragments, net_bufs #2 and #3. Both the node and frags pointers (they are the same, since they are unioned) point to the next fragment. 1.2 After enqueueing: +--------+ +--------+ +--------+ +--------+ +--------+ |q/slist |------|#1 node|------|#2 node|------|#3 node|------|q/slist | |node | | *flag | / | *flag | / | | / |node | | | | frags |/ | frags |/ | frags |/ | | +--------+ +--------+ +--------+ +--------+ +--------+ When enqueing a net_buf (in this case #1) that contains fragments, the current net_buf implementation actually enqueues all the fragments (in this case #2 and #3) as actual queue/slist items, since node and frags are one and the same in memory. This makes the enqueuing operation expensive and it makes it impossible to atomically dequeue. The `*flag` notation here means that the `flags` member has been set to `NET_BUF_FRAGS` in order to be able to reconstruct the frags pointers when dequeuing. After this patch, the layout changes considerably: 2.1 Before enqueueing: +--------+ +--------+ +--------+ |#1 node|--NULL |#2 node|--NULL |#3 node|--NULL | | | | | | | frags |-------| frags |-------| frags |------NULL +--------+ +--------+ +--------+ This is very similar to 1.1, except that now node and frags are different pointers, so node is just set to NULL. 2.2 After enqueueing: +--------+ +--------+ +--------+ |q/slist |-------|#1 node|-------|q/slist | |node | | | |node | | | | frags | | | +--------+ +--------+ +--------+ | +--------+ +--------+ | |#2 node|--NULL |#3 node|--NULL | | | | | +------------| frags |-------| frags |------NULL +--------+ +--------+ When enqueuing net_buf #1, now we only enqueue that very item, instead of enqueing the frags as well, since now node and frags are separate pointers. This simplifies the operation and makes it atomic. Resolves zephyrproject-rtos#52718. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
yonsch
pushed a commit
that referenced
this pull request
Mar 25, 2023
Add additional custom LE Channel Selection #2 tests to cover event and subevent mapping. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rapsberry pi pico PWM driver.
Signed-off-by: Radu Pirea pirea.radu@gmail.com