Skip to content

Conversation

@Norfeldt
Copy link
Contributor

@Norfeldt Norfeldt commented Jun 9, 2022

Not a fan of dropping the tests, but not sure if getting it to work (https://hung.dev/jest-vite) would be worth it in case the PR gets rejected. (it could also be considered if if it would be more correct to use vitest instead of jest?)

Not a fan of dropping the tests, but not sure if getting it to work (https://hung.dev/jest-vite) would be worth it in case the PR gets rejected.
@Norfeldt Norfeldt mentioned this pull request Jun 9, 2022
Copy link
Owner

@yosevu yosevu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @Norfeldt! I've been curious to try Vite and I'm already liking it better than CRA. I'm not familiar with vitest yet, will check it out.

@yosevu yosevu merged commit 636921b into yosevu:main Jun 18, 2022
@Norfeldt Norfeldt deleted the replace_CRA-with-vite branch June 18, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants