Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable kobuki Windows build #398

Open
wants to merge 11 commits into
base: melodic
Choose a base branch
from

Conversation

kejxu
Copy link

@kejxu kejxu commented Jul 18, 2019

update kobuki's ROS wrapper to enable the kobuki code base to build on Windows. A few changes in this pull request:

  • update boost::shared_ptr with std::shared_ptr
  • add minimal.win.launch that references base.win.launch, this is added as USB devices on Windows use COM ports and it does not seem feasible (afaik) to remap it to /dev/kobuki
  • no termio.h for Windows, read keyboard event from terminal with windows.h api and translate virtual key code to termio input so that the existing control logics can be reused

this port points to the melodic release branch because it currently only targets ROS1.melodic

@kejxu
Copy link
Author

kejxu commented Jul 18, 2019

@corot please excuse me for pinging =) Just noticed that the other pull request in this repository has not been updated for quite a while, just curious... are you still working on this repository? If not, is there anyone we should reach out to for code changes? We are planning on a batch of code changes to enable kobuki controller on Windows

@corot
Copy link
Collaborator

corot commented Apr 9, 2020

@corot please excuse me for pinging =) Just noticed that the other pull request in this repository has not been updated for quite a while, just curious... are you still working on this repository? If not, is there anyone we should reach out to for code changes? We are planning on a batch of code changes to enable kobuki controller on Windows

As you can see by the time lapse for answering, the answer is "almost not". I still use the code here, and do a minimum of maintenance. But I cannot handle this PR in particular because: a) I don't have my kobuki with me now b) I have never worked with Windows porting. Maybe @stonier can be more helpful here, as he worked a lot with ROS on Windows. But he has not a robot, and he's very busy.

@stonier
Copy link
Member

stonier commented Jul 29, 2020

I do have a robot actually, but no windows to test with and aye, more busy than I'd like to be, with most of my effort going into the ros2 port of kobuki. Short of finding maintainers with the cycles to diligently test / release the ROS1 kobuki code on both platforms for melodic, noetic, then the current status quo of minor fixes is the easiest way to guarantee no significant breakages occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants