Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftdi] fix rule installation and readme #50

Merged
merged 1 commit into from
Jan 9, 2020
Merged

[ftdi] fix rule installation and readme #50

merged 1 commit into from
Jan 9, 2020

Conversation

stonier
Copy link
Member

@stonier stonier commented Jan 9, 2020 •
edited
Loading

Fixes the install location of scripts (gets them out of polluting the global bin directory) and updates the readme.

Also accidentally included some commented msg constant name changes from yujinrobot/kobuki_msgs#11

@stonier stonier added the bug label Jan 9, 2020
@stonier stonier added this to the Eloquent milestone Jan 9, 2020
@stonier stonier self-assigned this Jan 9, 2020
clalancette
clalancette approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. I'll approve anyway.

kobuki_ftdi/CMakeLists.txt Show resolved Hide resolved
@stonier stonier merged commit 505fe53 into devel Jan 9, 2020
@stonier stonier deleted the stonier/ftdi_fixes branch January 9, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@stonier stonier

Labels
bug
Projects
None yet
Milestone
Eloquent
Development

Successfully merging this pull request may close these issues.
2 participants
@stonier @clalancette