feat: Set MACOSX_DEPLOYMENT_TARGET#202
Merged
yutannihilation merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS,
R CMD checkproduces this linker warning:ld: warning: object file (...unwind_protect_wrapper.o) was built for newer 'macOS'
version (26.2) than being linked (15.0)
unwind_protect_wrapper.ois compiled by the Rustcccrate (in savvy'sbuild.rs).Although we export
CCandCFLAGSto cargo, thecccrate does not derive thedeployment target from these flags. It has its own lookup chain:
MACOSX_DEPLOYMENT_TARGETenv var, thenxcrun --show-sdk-versionas fallback. SinceMACOSX_DEPLOYMENT_TARGETwas not set, it fell back to the SDK version (26.2), while R'sclang defaulted to 15.0 (from its target triple
arm64-apple-darwin24).Fix
Detect the macOS deployment target in
configureand export it viaBEFORE_CARGO_BUILDso the
cccrate picks it up. Detection order:MACOSX_DEPLOYMENT_TARGETenv var (if already set)-mmacosx-version-min=flag in R'sCC/CFLAGS__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__preprocessor macro from R's compilerReferences
-mmacosx-version-mindetection