Commit authors in changelog#74
Conversation
|
I think what we might want to do is add a configuration here that tells us to use the GitHub API to look up handles for each commit so we can properly build the |
|
Ha. That should be doable. https://stackoverflow.com/questions/44888187/get-github-username-through-primary-email this only works if their email is publicly visible. it is doable. |
|
I don't assume people will hit rate limits with this API. but if they run this in CI, they might. |
you mean, directly mention just the |
|
Yeah, instead of deriving like an |
|
Made changes.
|
|
@TwistingTwists Any updates on this? Would be great to have this in ❤️ |
|
Ah dang. I almost forgot about it. Will update this later this week |
- since usernames are looked up per commit, cache is implemented via persistent_term
- removed persistent_term - use github_username if possilbe - otherwise fallback to name from 'email' or commit.
TwistingTwists
force-pushed
the
commit-authors-inchangelog
branch
from
0c3e705 to
e4a175e
Compare
|
@zachdaniel ready for review. :) |
|
🚀 Thank you for your contribution! 🚀 |
2 participants
fix: #73
Contributor checklist
For example:
fix: Multiply by appropriate coefficient, orfeat(Calculator): Correctly preserve historyAny explanation or long form information in your commit message should be
in a separate paragraph, separated by a blank line from the primary message