Add inherited_labels #459
Merged
Add inherited_labels #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephane Tang <hi@stang.sh>
Signed-off-by: Stephane Tang <hi@stang.sh>
stang
requested review from
CyberDem0n,
Jan-M,
alexeyklyukin,
avaczi,
erthalion and
sdudoladov
as code owners
Member
|
@stang is there a chance that existing |
Contributor
Author
|
@sdudoladov - sorry, I was replying on the Issue (see: #456 (comment)) TL;DR: I don't think the |
Jan-M
reviewed
Jan 23, 2019
sdudoladov
reviewed
Jan 23, 2019
Member
|
@stang I left a couple of doc-related comments, otherwise I am happy with the change. |
stang
force-pushed
the
add-inherited-labels
branch
from
c382453 to
0a6f8d2
Compare
stang
force-pushed
the
add-inherited-labels
branch
2 times, most recently
from
340795c to
e141ae0
Compare
FxKu
reviewed
Feb 7, 2019
Member
FxKu
left a comment
FxKu
left a comment
There was a problem hiding this comment.
I like your contribution as well :)
Signed-off-by: Stephane Tang <hi@stang.sh>
stang
force-pushed
the
add-inherited-labels
branch
from
e141ae0 to
33dd488
Compare
sdudoladov
approved these changes
Feb 14, 2019
Member
sdudoladov
left a comment
sdudoladov
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @stang
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative of implementation of
inherit_labelssee: #456