Skip to content

Conversation

pierreozoux
Copy link

In the doc, this is now thee recommendation.

@FxKu
Copy link
Member

FxKu commented Oct 23, 2019

It requires more changes to switch to CRD-based config as the default. Currently, the deployment registers the OperatorConfiguration CRD. So this has to happen first before applying the configuration manifest. Unfortunately, when we reference the configuration manifest already in the deployment it causes the operator pod to fail until we apply the configuration yaml. Providing a CRD yaml that one can apply first would solve this issue.

On the other hand using the CRD-based config over the ConfigMap only makes a difference if we would also provide CRD validation. There's already #599 for this. The PR also contains a yaml for both CRDs the operator is using. I've already included your idea there :)

@pierreozoux
Copy link
Author

Great! Then I close mine ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants