fix(types): resolve four pre-existing svelte-check errors (#332)

* fix(types): resolve four pre-existing svelte-check errors

- nourishRelay: re-export NourishRelayResult so nourishDiscovery can
  import it from this module
- kitchens: add ValidSellerTier for the membership filter list; the
  getMembership return tier ('member') is not in membershipStore's
  MembershipTier union
- FoodstrFeedOptimized: annotate primalEvents.filter callback as
  NDKEvent (primalPrefetch is Promise<any>, which widened the array
  element to any)
- FoodstrFeedOptimized: widen kinds array at the single flagged
  subscribe site, matching the existing [1, 1068 as number] as number[]
  pattern used elsewhere in the file

svelte-check: 4 errors → 0 errors (127 warnings unchanged)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(kitchens): make KitchenDisplay.memberTier type match stored values

Copilot review on PR #332 flagged that the previous fix let 'member'
pass the validTiers filter and then be cast to membershipStore's
MembershipTier on assignment, leaving KitchenDisplay.memberTier holding
a value outside its declared union at runtime.

Introduce a shared KitchenMemberTier type ('member' | 'cook_plus' |
'pro_kitchen' | 'founders') on the marketplace types module, use it for
both KitchenDisplay.memberTier and ImplicitKitchen.memberTier, and drop
the now-misleading cast chain in kitchens.ts. MembershipBadge already
handles 'member' at runtime (its tierConfig has an entry for it) — its
tier prop is widened to admit it so KitchenCard passes cleanly without
a cast.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: spe1020 <sethsager@Seths-MacBook-Air.local>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: 3 people

package.json

@@ -1,7 +1,7 @@
 {
   "name": "zap.cooking",
   "license": "MIT",
-  "version": "4.2.280",
+  "version": "4.2.282",
   "private": true,
   "scripts": {
     "dev": "vite dev",

src/components/FoodstrFeedOptimized.svelte

@@ -2436,7 +2436,7 @@
                 }
               }
 
-              const foodEvents = primalEvents.filter((event) => {
+              const foodEvents = primalEvents.filter((event: NDKEvent) => {
                 if ($userPublickey) {
                   const mutedUsers = getMutedUsers();
                   const authorKey = event.author?.hexpubkey || event.pubkey;
@@ -2643,7 +2643,7 @@
       // relay-appropriate REQs internally. This replaces N/100 open subs.
       const sub = $ndk.subscribe(
         {
-          kinds: [1, 1068],
+          kinds: [1, 1068 as number] as number[],
           authors: followedPubkeysForRealtime,
           since
         },

src/components/MembershipBadge.svelte

@@ -5,7 +5,11 @@
   import FireIcon from 'phosphor-svelte/lib/Fire';
   import type { MembershipTier } from '$lib/membershipStore';
 
-  export let tier: MembershipTier;
+  // Also accept 'member' — the tier string returned by the membership
+  // service for the base paid tier. tierConfig has a 'member' entry, so
+  // this has always been a runtime-valid input; the declared type just
+  // didn't admit it.
+  export let tier: MembershipTier | 'member';
   export let size: 'sm' | 'md' | 'lg' = 'md';
   export let showLabel: boolean = false;
 

src/lib/marketplace/kitchens.ts

@@ -13,13 +13,13 @@ import {
 	type Kitchen,
 	type KitchenFormData,
 	type ImplicitKitchen,
-	type KitchenDisplay
+	type KitchenDisplay,
+	type KitchenMemberTier
 } from './types';
 import { MARKETPLACE_RELAYS } from './products';
 import { addClientTagToEvent } from '$lib/nip89';
 import { profileCacheManager } from '$lib/profileCache';
 import { getMembership } from '$lib/stores/membershipStatus';
-import type { MembershipTier } from '$lib/membershipStore';
 import { SUPPORTED_CURRENCIES, type CurrencyCode } from '$lib/currencyStore';
 
 // NIP-85 Trusted Assertions — service relay for trust rank lookups
@@ -770,11 +770,11 @@ export async function fetchAllKitchenDisplays(
 	const allSellerPubkeys = qualifiedDisplays.map((d) => d.pubkey);
 	try {
 		const membershipStatuses = await getMembership(allSellerPubkeys);
-		const validTiers: MembershipTier[] = ['member', 'cook_plus', 'pro_kitchen', 'founders'];
+		const validTiers: KitchenMemberTier[] = ['member', 'cook_plus', 'pro_kitchen', 'founders'];
 		for (const d of qualifiedDisplays) {
 			const status = membershipStatuses[d.pubkey];
-			if (status?.active && validTiers.includes(status.tier as MembershipTier)) {
-				d.memberTier = status.tier as MembershipTier;
+			if (status?.active && validTiers.includes(status.tier as KitchenMemberTier)) {
+				d.memberTier = status.tier as KitchenMemberTier;
 			}
 		}
 	} catch (e) {

src/lib/marketplace/types.ts

@@ -5,9 +5,14 @@
  */
 
 import type { NDKEvent } from '@nostr-dev-kit/ndk';
-import type { MembershipTier } from '$lib/membershipStore';
 import type { CurrencyCode } from '$lib/currencyStore';
 
+// Seller-grade tiers actually stored on a KitchenDisplay. Narrower than
+// both $lib/membershipStore.MembershipTier (has 'open', which never
+// makes sense for a seller badge) and $lib/stores/membershipStatus
+// .MembershipTier ('unknown' is filtered out before assignment).
+export type KitchenMemberTier = 'member' | 'cook_plus' | 'pro_kitchen' | 'founders';
+
 // Commerce state enum lives here (instead of commerceState.ts) so that the
 // Product / ProductFormData types can reference it without creating a module
 // cycle. commerceState.ts re-exports these for backward-compatible imports.
@@ -154,7 +159,7 @@ export interface Kitchen {
 	defaultCurrency?: CurrencyCode; // Default currency for new products in this store
 	productCount?: number; // computed client-side
 	trustRank?: number; // NIP-85 trust score 0-100 (computed)
-	memberTier?: MembershipTier; // zap.cooking membership tier
+	memberTier?: KitchenMemberTier; // zap.cooking membership tier
 	createdAt: number;
 	event: NDKEvent;
 }
@@ -181,7 +186,7 @@ export interface ImplicitKitchen {
 	defaultCurrency?: CurrencyCode;
 	productCount: number;
 	trustRank?: number; // NIP-85 trust score 0-100 (computed)
-	memberTier?: MembershipTier; // zap.cooking membership tier
+	memberTier?: KitchenMemberTier; // zap.cooking membership tier
 	isImplicit: true;
 }
 

src/lib/nourish/nourishRelay.ts

@@ -18,6 +18,7 @@ import {
   type NourishRelayResult,
   type IngredientSignal
 } from './types';
+export type { NourishRelayResult } from './types';
 
 const PANTRY_RELAY = 'wss://pantry.zap.cooking';
 // Pantry query timeout. Calibrated to 2s — healthy pantry median sits