handle an OAUTH2 offline token refresh #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laura Pardo <lpardo@redhat.com>
Contributor
Author
|
any updates on this? Am I missing a previous step or anything for this to get reviewed/accepted? |
kingthorin
requested changes
Sep 7, 2021
Member
kingthorin
left a comment
kingthorin
left a comment
There was a problem hiding this comment.
Just minor things for consistency
Member
|
The conflict in CHANGELOG.md also needs to be addressed. |
Member
|
To address the DCO requirement you'll need to sign-off the commit(s): |
Co-authored-by: Rick M <kingthorin@users.noreply.github.com> Signed-off-by: Laura Pardo <lpardo@redhat.com>
kingthorin
reviewed
Sep 14, 2021
Member
|
To address the DCO requirement you'll need to sign-off the commit(s): |
thc202
approved these changes
Sep 17, 2021
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OAUTH2 offline token handle for ZAP users.
Authentication/OfflineTokenRefresher.js will automatically fetch the new access token for every unauthorized request determined by the "Logged Out" or "Logged In" indicator previously set in Context -> Authentication.
HTTP Sender/AddBearerTokenHeader.js will add the new access token to all requests in scope made by ZAP (except the authentication ones) as an "Authorization: Bearer [access_token]" HTTP Header.