Suggections(vue): suggestions in vue projects broke in latest release

[Ilanaya]

STR:

1. Vue project with options API (didn't test on composition api syntax), e.g. this simple one
2. Vue support is enabled: "tsEssentialPlugins.enableVueSupport": true
3. Volar config path is overriden: "volar.vueserver.configFilePath": "<PATH_TO_VSCODE>\\.vscode\\extensions\\zardoy.ts-essential-plugins-0.0.53\\volarConfig.js",
4. Trigger suggestions in this line of mentioned project https://github.com/maIIady/pinia-test/blob/28a1ddcd5d366d4255ca88e43a94ccd31001baaf/src/App.vue#L39

AR:

P.S. I'm gonna eventually investigate it myself but I don't have time rn.
@zardoy It definitely broke in one of the commits after this one - 5697844 (everything was good when I developed it). Maybe you have an idea/quick suggestion where to look?

[zardoy]

@maIIady First of all I cannot reproduce, tested even with empty profile with only volar and this extension enabled (and only enableVueSupport was enabled), I'm getting testMethod completion. Secondly I see volar started to ignore LS errors and patch output instead, so you have debug. Clone vue/language-tools, start watch and Launch Client debug (with all conflicting extensions disabled), and then launch Attach to Vue Semantic Server in this repo. Try setting breakpoints to:

• check prior output of LS:

  typescript-vscode-plugins/typescript/src/completionsAtPosition.ts

  Line 106 in 9641211

  const ensurePrior = () => {

• check filtered output by us:

  typescript-vscode-plugins/typescript/src/decorateProxy.ts

  Line 88 in 9641211

  return result.completions

[Ilanaya]

I had TS nightly enabled which caused the issue

[Ilanaya]

@zardoy As you are probably already aware of TS 5 exported API changes. Calling Object.defineProperty in patchMethod will always result in error as
The exported API is no longer defined as a "configurable" object, so operations which attempt to modify the package at runtime such as const ts = require("ts"); ts.readJson = ... will throw.

For some reason I don't quite understand, it only breaks in vue files (with TS 5+ ofc) and I couldn't reproduce it in any ts project.

I don't want to bother you much with my problems, but maybe you have plans/ideas on how to handle this? As I can always use TS < 5 in my vue projects I don't suffer much from this issue and can invest some time into it.

If you are curious, to reproduce

1. Open the project I've mentioned when I open the current issue or any other vue project
2. Use TS 5+, tsEssentialPlugins.enableVueSupport: true
3. Just trigger suggestions for some time. Eventually, you'll get an error like below
   

[zardoy]

This is really weird, as:

1. I thought this exception should be handled in our codebase
2. It should affect codefixes, but not completions

[zardoy]

Oh now I see, it crashes whole LS. Can you in https://github.com/zardoy/typescript-vscode-plugins/blob/develop/typescript/src/codeFixes.ts replace throw err (L88) with console.error

[Ilanaya]

Thanks already, gonna test it in an hour