Volar 1.6+ support

[Ilanaya]

Hello, I recently upgraded Volar from v1.4.4 to v1.6+, but it seems that the support for it is no longer functioning properly. It looks like there is a more complex underlying issue than just with Volar config setting change (volar.vueserver.configFilePath -> vue.server.configFilePath)

I personally looked into it but I wasn't able to find any results. It seems as though the extension isn't activated at all, as I didn't see either the message "Ts Essential Plugins Activated" or "Failed to activate tsEssentialPlugins" in the extension output.

Could you please provide some assistance or advice on what could break?

P.S. Tested it with an empty profile with only this settings enabled:
code --list-extensions output:

Vue.volar
zardoy.ts-essential-plugins

Related settings:

{
  "tsEssentialPlugins.enableVueSupport": true,
  "vue.server.configFilePath": "<PATH>"
}

[zardoy]

I personally looked into it but I wasn't able to find any results. It seems as though the extension isn't activated at all

I updated setting and I see TS Essentials Plugins activated message in Vue Semantic Server output. It works.

[Ilanaya]

Ok, sorry, this indeed works :)

But setting to remove component from defintions broke

E.g. hovering over here https://github.com/maIIady/pinia-test/blob/master/src/App.vue#L4

Gonna end up with this output -

So there is no more __VLS_componentsOption to filter. This is mostly volar's issue and, as I can see, there is not way to handle it on our side (or not?)

PS. You can close the issue, thanks for help

[zardoy]

Yes let's include this improvements for volar, and also let's include fix for code actions formatting
Update: sorry didn't answer your question. No, there is still a way to filter these defs from our side

[Ilanaya]

Can you provide some tips how to filter this refs? And I don't get what fix for code actions formatting you mentioned?

Yes let's include this improvements for volar, and also let's include fix for code actions formatting Update: sorry didn't answer your question. No, there is still a way to filter these defs from our side

Btw, is there a chance we could meet somewhere to work on it and maybe some other features?

[zardoy]

Can you provide some tips how to filter this refs?

So far I was using this detection

typescript-vscode-plugins/typescript/src/completionsAtPosition.ts

Line 274 in 706ec59

if (ts.isArrayLiteralExpression(node) && lines[curLine - 1] === '// @ts-ignore' && lines[curLine - 2]?.startsWith('__VLS_components')) {

And I don't get what fix for code actions formatting you mentioned?

vuejs/language-tools#2425 , thought it might also annoy you. If it doesn't then there is no priority for this one

Btw, is there a chance we could meet somewhere to work on it and maybe some other features?

Ofc, just as always :)