Skip to content

Drop Python 3.7#405

Merged
joshmoore merged 1 commit intozarr-developers:mainfrom
jakirkham:drop_py37
Dec 14, 2022
Merged

Drop Python 3.7#405
joshmoore merged 1 commit intozarr-developers:mainfrom
jakirkham:drop_py37

Conversation

@jakirkham
Copy link
Copy Markdown
Member

@jakirkham jakirkham commented Dec 13, 2022

Fixes #381

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@jakirkham jakirkham mentioned this pull request Dec 13, 2022
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #405 (174df01) into main (7d8f976) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          53       54    +1     
  Lines        2023     2093   +70     
=======================================
+ Hits         2022     2092   +70     
  Misses          1        1
Impacted Files Coverage Δ
numcodecs/abc.py 100.00% <0.00%> (ø)
numcodecs/__init__.py 100.00% <0.00%> (ø)

@joshmoore joshmoore enabled auto-merge (squash) December 13, 2022 09:25
joshmoore
joshmoore approved these changes Dec 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jakirkham
Copy link
Copy Markdown
Member Author

jakirkham commented Dec 14, 2022

Ha! Missed this one thing 😉 Fixing now

Screen Shot 2022-12-13 at 5 15 00 PM

@joshmoore joshmoore merged commit 824deb4 into zarr-developers:main Dec 14, 2022
@jakirkham jakirkham deleted the drop_py37 branch December 14, 2022 01:17
@jakirkham
Copy link
Copy Markdown
Member Author

jakirkham commented Dec 14, 2022

Dropped Python 3.7 from required checks. Also add Python 3.10 & 3.11 to required checks.

@jakirkham jakirkham mentioned this pull request Dec 14, 2022
Merged
7 tasks
@jakirkham
Copy link
Copy Markdown
Member Author

jakirkham commented Dec 14, 2022

Caught some leftover Python 3.7 compatibility code. Removing in PR ( #406 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Python 3.7?

2 participants

@jakirkham @joshmoore