Skip to content

Drop unused Python 3.7 compatibility code#406

Merged
jakirkham merged 1 commit intozarr-developers:mainfrom
jakirkham:drop_py37_compat
Dec 14, 2022
Merged

Drop unused Python 3.7 compatibility code#406
jakirkham merged 1 commit intozarr-developers:mainfrom
jakirkham:drop_py37_compat

Conversation

@jakirkham
Copy link
Copy Markdown
Member

Now that Python 3.8 is the minimum supported version, there is no need for this typing_extensions branch or a dependency on typing-extensions. So drop both to cleanup the code. Also should bring coverage back up.

xref: #405

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@jakirkham jakirkham mentioned this pull request Dec 14, 2022
7 tasks
@jakirkham jakirkham enabled auto-merge (squash) December 14, 2022 01:59
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2022

Codecov Report

Merging #406 (1237569) into main (4a029c9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #406      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files          54        54              
  Lines        2093      2089       -4     
===========================================
- Hits         2092      2089       -3     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
numcodecs/ndarray_like.py 100.00% <100.00%> (+2.38%) ⬆️

Now that Python 3.8 is the minimum supported version, there is no need
for this `typing_extensions` branch or a dependency on
`typing-extensions`. So drop both to cleanup the code. Also should bring
coverage back up.
@jakirkham jakirkham disabled auto-merge December 14, 2022 02:12
@jakirkham jakirkham enabled auto-merge (squash) December 14, 2022 02:12
@jakirkham jakirkham merged commit f9f4cd3 into zarr-developers:main Dec 14, 2022
@jakirkham jakirkham deleted the drop_py37_compat branch December 14, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant