Skip to content

Conversation

@jakirkham
Copy link
Member

As these bits may or may not be built depending on whether C-extensions are supported, have pytest skip them if they are not importable.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

As these bits may or may not be built depending on whether C-extensions
are supported, have pytest skip them if they are not `import`able.
@jakirkham jakirkham requested a review from a team September 11, 2020 01:00
@jakirkham jakirkham changed the title Use pytest.importorskip for C-extension tests Optionally skip C-extension tests Sep 11, 2020
@jakirkham
Copy link
Member Author

Going to go ahead and merge to fix PyPy builds. Hopefully that helps PR ( #248 ) and PR ( conda-forge/numcodecs-feedstock#53 ) out.

@jakirkham jakirkham merged commit e73ea8b into zarr-developers:master Sep 11, 2020
@jakirkham jakirkham deleted the use_pytest_importorskip branch September 11, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant