-
-
Notifications
You must be signed in to change notification settings - Fork 366
Tell codespell to skip fixture / fix pre-commit
#1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tell codespell to skip fixture / fix pre-commit
#1197
Conversation
d71a17e to
ee74ce5
Compare
|
Maybe we can also get rid of the hard |
|
I guess I can change zarr-python/.pre-commit-config.yaml Lines 5 to 6 in e8f6fef
I can do that in a different merge request - to avoid completely rewriting this one. |
|
It's ok if we want to lump these altogether. Maybe we can retitle the PR to capture that |
ee74ce5 to
d71a17e
Compare
This will avoid this kind of warnings: WARNING: Decoding file using encoding=utf-8 failed: fixture/8/0/11 WARNING: Trying next encoding iso-8859-1 Seen in: https://results.pre-commit.ci/run/github/48049137/1666036569.rj425j-vQKyvNbJ0CUHdcQ
d71a17e to
4bbb4d4
Compare
|
I added a second commit to remove the hard Now pre-commit works on my workstation: |
fixturefixture / fix pre-commit
Codecov Report
@@ Coverage Diff @@
## main #1197 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 35 35
Lines 14136 14135 -1
=======================================
- Hits 14135 14134 -1
Misses 1 1
|
|
Thanks @DimitriPapadopoulos! 🙏 |
This will avoid this kind of warnings with codespell 2.2.2:
Seen in:
https://results.pre-commit.ci/run/github/48049137/1666036569.rj425j-vQKyvNbJ0CUHdcQ
TODO: