Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Oct 27, 2025

Sets up very basic benchmarks using asv.

I don't want to write up all of the benchmarks we need in this PR. this is just setting up the basic infrastructure.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 27, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Oct 27, 2025

closes #337

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Oct 27, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Oct 27, 2025

there might be better / alternative tools than asv for this purpose, like codspeed. I picked asv because that's what numpy is using, but the choice of tool is definitely a degree of freedom here.

@maxrjones
Copy link
Member

there might be better / alternative tools than asv for this purpose, like codspeed. I picked asv because that's what numpy is using, but the choice of tool is definitely a degree of freedom here.

IMO it depends on your goals. If you want to run comparisons between two branches locally then asv can be fine. If you want the benchmarks integrated into CI then codspeed would work better. I personally prefer codspeed because I've found it easier to integrate with existing tests rather than needing separate a benchmarking setup.

@d-v-b
Copy link
Contributor Author

d-v-b commented Oct 28, 2025

generally I'm hearing more enthusiasm for something like codspeed instead of asv, and the argument in favor of benchmarks being integrated with our tests is persuasive to me, so I'm going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants