Update MemoryStore.get signature to match other stores #3581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MemoryStore's .get function has a different function signature compared to other stores such as LocalStore. This PR ensures the default value for the
prototypeparameter isNonefor the MemoryStorehttps://github.com/keller-mark/zarr-python/blob/7d0b62da45f6d8e5f5d93953d71fe9ef76f79e1c/src/zarr/storage/_local.py#L193
More generally, userland code should be able to assume a generic Store API that has consistent function signatures for important methods such as
Store.get. This is an important benefit of the Store abstraction.TODO:
docs/user-guide/*.mdchanges/