Test on Python 3.9-dev, also remove sudo #637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.9 have been release a few weeks ago, and sudo seem unnecessay.
Contributor
Author
|
Seem to fail because of h5py. |
Contributor
Author
|
libh5py does not seem to work yet on 3.9 |
Member
|
Would xfailing some tests on Python 3.9 help? |
Contributor
Author
Yeah, likely or maker them skipif if we can't import h5py. Right now it's more a question on conditionally trying to install h5py as CI fails before starting the tests. |
Member
|
Guessing this will need an update to move to GH Actions |
Member
|
Yeah, actually, looking at it, I'm not sure it's worth keeping it around. Closing. If anything is salvageable, let's do that in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.9 have been release a few weeks ago, and sudo seem unnecessay.